Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134974719
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java ---
@@ -37,16 +37,14 @@
*/
@Test
public void testBrokerRestart() throws Exception {
- for (int i = 0; i < 2; i++) {
- BrokerController brokerController = new BrokerController(
- new BrokerConfig(),
- new NettyServerConfig(),
- new NettyClientConfig(),
- new MessageStoreConfig());
- assertThat(brokerController.initialize());
- brokerController.start();
- brokerController.shutdown();
- }
+ BrokerController brokerController = new BrokerController(
--- End diff --
As there is more whole startup in test case , I think there no need to do
this. Any questions?IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
