Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135431420
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -97,54 +110,46 @@ public MessageExtBrokerInner buildMessage() {
@Test
public void testGroupCommit() throws Exception {
- long totalMsgs = 100;
+ long totalMsgs = 10;
QUEUE_TOTAL = 1;
MessageBody = StoreMessage.getBytes();
- MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
- messageStoreConfig.setMapedFileSizeCommitLog(1024 * 8);
- messageStoreConfig.setFlushDiskType(FlushDiskType.SYNC_FLUSH);
- MessageStore master = new DefaultMessageStore(messageStoreConfig,
null, new MyMessageArrivingListener(), new BrokerConfig());
- boolean load = master.load();
- assertTrue(load);
+ for (long i = 0; i < totalMsgs; i++) {
+ messageStore.putMessage(buildMessage());
+ }
- master.start();
- verifyThatMasterIsFunctional(totalMsgs, master);
+ for (long i = 0; i < totalMsgs; i++) {
+ GetMessageResult result = messageStore.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
+ assertThat(result).isNotNull();
+ result.release();
+ }
+ verifyThatMasterIsFunctional(totalMsgs, messageStore);
}
private void verifyThatMasterIsFunctional(long totalMsgs, MessageStore
master) {
- try {
- for (long i = 0; i < totalMsgs; i++) {
- master.putMessage(buildMessage());
- }
-
- for (long i = 0; i < totalMsgs; i++) {
- GetMessageResult result = master.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
- assertThat(result).isNotNull();
- result.release();
-
- }
- } finally {
- master.shutdown();
- master.destroy();
+ for (long i = 0; i < totalMsgs; i++) {
+ master.putMessage(buildMessage());
+ }
+
+ for (long i = 0; i < totalMsgs; i++) {
+ GetMessageResult result = master.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
+ assertThat(result).isNotNull();
+ result.release();
+
}
}
@Test
public void testPullSize() throws Exception {
- MessageStore messageStore = buildMessageStore();
- boolean load = messageStore.load();
- assertTrue(load);
- messageStore.start();
String topic = "pullSizeTopic";
for (int i = 0; i < 32; i++) {
MessageExtBrokerInner messageExtBrokerInner = buildMessage();
messageExtBrokerInner.setTopic(topic);
messageExtBrokerInner.setQueueId(0);
- PutMessageResult putMessageResult =
messageStore.putMessage(messageExtBrokerInner);
+ messageStore.putMessage(messageExtBrokerInner);
}
//wait for consume queue build
- Thread.sleep(100);
+ Thread.sleep(10);
--- End diff --
In test scenario, 10ms is enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
