OK. Sedat's latest patch looks good and I'm ready to commit.
I have updated the proposal to reflect the fact that no new table or POJO is required, instead Sedat added a new field the the 'rolleruser' table and a new method to UserManager to fetch a user by activation code. Unless there are objections I plan on committing the code today. Thanks Sedat! - Dave On 3/29/07, Dave <[EMAIL PROTECTED]> wrote:
Thanks Sedat, I hope to have some time this week to evaluate the patch. - Dave On 3/29/07, sedat ciftci <[EMAIL PROTECTED]> wrote: > I notice that in the ver6 of my patch, I forget to > remove two lines of code that I wrote for testing > purpose in > org.apache.roller.business.hibernate.HibernateUserManagerImpl. > I remove these test codes and update the patch again: > > http://www.jroller.com/resources/s/sedat/newRollerPropertyVer7.jar > > Sedat Çiftçi > > --- sedat ciftci <[EMAIL PROTECTED]> wrote: > > > Here is the updated patch: > > > http://jroller.com/resources/s/sedat/newRollerPropertyVer6.jar > > > > Sedat Çiftçi > > > > --- Dave <[EMAIL PROTECTED]> wrote: > > > > > On 3/23/07, sedat ciftci <[EMAIL PROTECTED]> > > > wrote: > > > > If you prefer that design, I can change it and > > > > re-submit the patch. > > > > Sedat Çiftçi > > > > > > Yes, please. I think the consensus is that we'd > > > rather avoid new table > > > creation in this enhancement. > > > > > > - Dave > > > > > > > > > > > > > > --- Dave <[EMAIL PROTECTED]> wrote: > > > > > > > > > On 3/21/07, sedat ciftci > > <[EMAIL PROTECTED]> > > > > > wrote: > > > > > > Yes, it can also be done with this design. > > > Note > > > > > that, > > > > > > in this design you have to clear the > > > > > activationCode > > > > > > (or make something else, to mark that it is > > > used) > > > > > > after the account is activated (Also in my > > > design, > > > > > I > > > > > > delete the related record from useractivate > > > > > table). > > > > > > The reason behind this requirement can be > > > > > explained as > > > > > > follows: > > > > > > Let's assume that a user registers with > > e-mail > > > > > > activation and assume that the related > > > > > activationCode > > > > > > is not deleted. After a while, admin user > > > wants to > > > > > > disable the account of this user from the > > > "User > > > > > Admin" > > > > > > menu of the Server Administration and > > disables > > > it. > > > > > > Then, if the user clicks the activation link > > > in > > > > > the > > > > > > sent activation mail (assume user stores it; > > > did > > > > > not > > > > > > delete it), his/her account is enabled > > again. > > > > > Because > > > > > > of this simple scenario, do not forget to > > mark > > > the > > > > > > activated accounts so that the link in the > > > sent > > > > > > activation mail will not be used again once > > it > > > is > > > > > > used. > > > > > > > > > > Sedat, > > > > > > > > > > Are you willing to change the design to remove > > > the > > > > > new table and then > > > > > re-submit the patch? > > > > > > > > > > - Dave > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ____________________________________________________________________________________ > > > > Sucker-punch spam with award-winning protection. > > > > Try the free Yahoo! Mail Beta. > > > > > > > > > > http://advision.webevents.yahoo.com/mailbeta/features_spam.html > > > > > > > > > > > > > > > > > > ____________________________________________________________________________________ > > Don't get soaked. Take a quick peek at the forecast > > with the Yahoo! Search weather shortcut. > > http://tools.search.yahoo.com/shortcuts/#loc_weather > > > > > > > ____________________________________________________________________________________ > The fish are biting. > Get more visitors on your site using Yahoo! Search Marketing. > http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php >
