On 4/3/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
Are those properties supposed to be in the runtime config? The proposal
doesn't specify.
They are in the starup config and email activation defaults to true.
The "user.account.activation.enabled" and
"user.account.activation.mail.from" should probably be runtime configs
instead and default to disabled, like our other email notification
settings.
What do others think?
Also, is there a reason why the activation code needs to be 255
characters? I would think something much smaller would suffice, like 64?
Currently, the length is configurable and defaults to 128. The code
generation logic looks like this:
private String generateActivationCode() {
int length = RollerConfig
.getIntProperty("user.account.activation.code.length");
if (length < 32) {
length = 32;
} else if (length > 255) {
length = 255;
}
char[] chars = new char[length];
for (int i = 0; i < length; i++) {
int randNumber = (int) (Math.random() * 16);
switch (randNumber) {
case 0:
chars[i] = '0';
break;
case 1:
chars[i] = '1';
break;
case 2:
chars[i] = '2';
break;
etc.
Might be better to use the Java 5 UUID generator instead.
Both of those changes are pretty easy for me to make in my workspace.
- Dave
