That's fine with me since I prefer to work on code more than proposals anyways, but in general I think it would be nice to hear a little more about how the DatabaseProvider, MailSessionProvider, and the bootstrapping code will work together. I am also still unsure about how you are planning to change the RollerContext initialization process to properly tie in with the bootstrapping process.

I think what I feel is mostly missing from the proposal is some kind of indication of the overall flow of events. As I said before, I think you've touched on all the places that will be changed and a little about how they will change, but there is no real concept of how the whole thing will work together.

-- Allen


Dave wrote:
I just added a note about a DatabaseProvider to the proposal as Allen suggested.

And a heads up: I'm moving ahead with the work outlined in this
proposal and targeting the trunk. For now I am not going to use Guice
or any other DI framework, since consensus is not clear. I'll work on
Guice separately in the roller_guice branch.

Why move ahead? I want to get the database creation and auto-upgrade
stuff in place as soon as possible, since it's probably the most risky
part of the work -- and it applies no matter what we decide about DI.

- Dave

Reply via email to