On Thu, Jan 29, 2009 at 6:45 AM, Emmanouil Batsis (Manos) <[email protected]> wrote: > Just wanted to introduce myself to the list and let you know I added a > couple of patches to jira, namely > > * SiteModel.getNewWeblogs javadoc fix, functionality improovement and patch > [1] > * Add "named" pin support[2] > > I'm rather errr, new to JPA, struts2 and velocity so these may not be of the > greatest quality etc. The "named pin" is rather incomplete for inclusion as > it only does it for JPA (VS hibernate) and mysql. It's design is also > suboptimal, e.g. it adds a new column to the weblogentry table VS a new > table (should be null in most rows). > > However, I'm willing to work more on these (or any other patches we submit), > as well as a new or modified main template to include this in a future > release if there's enough interest. > > [1] http://issues.apache.org/roller/browse/ROL-1780 > [2] http://issues.apache.org/roller/browse/ROL-1786
OK, I finally got a chance to take a look at these patches. Unfortunately, I ran into a couple of issues: 1) There is a local path built into the patches "/Users/manos/lib/roller_4.1" I get the message "patch cannot be applied in this context" when I attempt to apply them against either the trunk or the 4.0 branch. I create my patches with "svn diff > patchfile.txt" and it creates relative instead of absolute paths. 2) They are made against the Roller 4.0 code base These are new features and as such, should really go into the trunk. If you resubmit and fix at least item #1, I'll take another look. Thanks, - Dave
