On Fri, Feb 6, 2009 at 1:42 PM, Emmanouil Batsis (Manos) <[email protected]> wrote:
>> 1) There is a local path built into the patches
>> "/Users/manos/lib/roller_4.1"
>> I get the message "patch cannot be applied in this context" when I
>> attempt to apply them against either the trunk or the 4.0 branch. I
>> create my patches with "svn diff > patchfile.txt" and it creates
>> relative instead of absolute paths.
>
>> 2) They are made against the Roller 4.0 code base
>> These are new features and as such, should really go into the trunk.
>
>
> Done [1] for the trunk, but couldn't update "Affects Version/s:" in jira.
>
> Also, I dunno why eclipse insists using absolute paths in the patches. I
> modified all these in the new patch and then tried to apply the patch in
> roller project's basedir; works OK.
>
> [1] https://issues.apache.org/roller/browse/ROL-1786

Sorry about the delay. I am looking at this now and hope to have some
more comments very soon.

- Dave

Reply via email to