mbien commented on code in PR #159:
URL: https://github.com/apache/roller/pull/159#discussion_r3940112853
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java:
##########
@@ -76,14 +76,14 @@ public String execute() {
if (mediaFile.isImageFile()) {
link = "<p>" + mediaFile.getName() + "</p>";
- link += "<a href='<url>'><img src='<urlt>'
alt='<name>' width='<width>' height='<height>'></img></a>";
+ link += "<a href=\"<url>\"><img src=\"<urlt>\"
alt=\"<name>\" width=\"<width>\" height=\"<height>\" /></a>";
Review Comment:
so the fix is the missing `/` of this line and the quote change is to match
other generated code? I see usage of both `href='` and `href="` but double
quote is more common so thats good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
