mraible commented on code in PR #159:
URL: https://github.com/apache/roller/pull/159#discussion_r4107460659
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java:
##########
@@ -76,14 +76,14 @@ public String execute() {
if (mediaFile.isImageFile()) {
link = "<p>" + mediaFile.getName() + "</p>";
- link += "<a href='<url>'><img src='<urlt>'
alt='<name>' width='<width>' height='<height>'></img></a>";
+ link += "<a href=\"<url>\"><img src=\"<urlt>\"
alt=\"<name>\" width=\"<width>\" height=\"<height>\" /></a>";
Review Comment:
Close. There are two changes on that line, and together they make the markup
identical to what the entry editor's media chooser inserts, which is the path
that renders correctly:
- `</img>` becomes a self-closing `/>`, since `img` is a void element and
the closing tag is invalid. That's the `/` you spotted.
- The attributes switch from single to double quotes, which also matches the
other generated markup.
I changed both together to match the working path, so I can't say which of
the two broke rendering on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
