snoopdave commented on PR #160:
URL: https://github.com/apache/roller/pull/160#issuecomment-6401722395
I will try these themes out locally and submit a review, but Codex found a
couple issues:
🤖 Codex: Reviewed head a1819c50f3. I found three issues worth fixing before
merge.
1. Archives silently omit posts older than the newest 100. All three themes
use getRecentWeblogEntries("nil", 100) without pagination or a calendar. On an
established weblog, earlier posts disappear from the archive browser. Add
navigation to the remaining history.
[Casper](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/casper/archives.vm#L2),
[Minima](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/minima/archives.vm#L18),
[PaperMod](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/papermod/archives.vm#L15)
2. Minima and PaperMod drop navigation between days and months. Their
controls only use prevLink and nextLink, which paginate within the current
collection. They ignore prevCollectionLink and nextCollectionLink, which move
between dates. A month containing one page of entries consequently has no
archive navigation. Casper handles these links correctly. [Minima
controls](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/minima/post-list.vm#L28),
[PaperMod
controls](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/papermod/post-list.vm#L34)
3. Minima can fail rendering on an oversized numeric page parameter. Its
digits-only check accepts values such as 999999999999999999999, then
Integer.parseInt() throws. Roller’s request parser already handles that invalid
input, but the template parses the raw value again. I reproduced the exception
with Velocity 2.4.1. Use a validated page value or bounded conversion. [Failing
expression](https://github.com/apache/roller/blob/a1819c50f3efb94cd39dfc9feda569c99808679d/app/src/main/webapp/themes/minima/post-list.vm#L39-L41)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
