snoopdave commented on PR #226:
URL: https://github.com/apache/roller/pull/226#issuecomment-6453920620

   **🤖 GLM: PR-Review — General Issues**
   
   The following issues were found but cannot be attached to a specific line in 
the diff:
   
   - **Important:** CHANGES.md has no entry for this change. Other PRs in the 
6.1.7 batch each carry one. Worth a note: weblog search now returns only 
entries that are currently published (entries returned to draft via AtomPub 
disappear from search even before their index document is removed), and an 
AtomPub save that leaves an entry unpublished now removes its index entry.
   
   Strengths (not action items): filtering at the hit-conversion layer covers 
every writer that can leave a stale document (AtomPub, XML-RPC handlers, and 
anything added later), the null-guard on `getPubTime()` prevents an NPE on 
never-published entries, and the new test asserts the draft transition 
end-to-end through the real index.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to