snoopdave commented on PR #241: URL: https://github.com/apache/roller/pull/241#issuecomment-6805238599
🐞Claude Issue: **PR-Review: General Issues** The following issue was found but cannot be attached to a specific line in the diff: - **Important:** `app/src/main/resources/sql/droptables.sql` (lines 32–34) still drops `pingqueueentry`, `autoping` and `pingtarget`. A fresh 7.0 schema no longer has these tables, so the script now issues three failing statements. The Derby test harness (`DerbyJunitExtension`, `DerbyManager`) and `createtestdata.gy` run this script. Remove the three lines. Runtime check (2026-11-11, PR head 39d203c78, Tomcat 11 / JDK 17, Postgres copy of the rollerweblogger.org DB at version 615): - The upgrade ran `610-to-700-migration.sql`, dropped the three tables, removed the `pings.%` properties and the `PingQueueTask` lock, and set the version to 700. - The menus and settings pages show no ping items, and the old ping URLs return 404. - Saving a draft, publishing it and deleting it all worked with no ping-related log output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
