snoopdave commented on code in PR #241: URL: https://github.com/apache/roller/pull/241#discussion_r4542366135
########## app/src/main/resources/sql/610-to-700-migration.vm: ########## @@ -0,0 +1,32 @@ +#** + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. The ASF licenses this file to You + under the Apache License, Version 2.0 (the "License"); you may not + use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. For additional information regarding + copyright in this work, please see the NOTICE file in the top level + directory of this distribution. +*# + +-- Remove the obsolete weblog update ping feature. Drop the referencing table first. +#if ($db.DBTYPE == "DERBY") +-- Derby has no DROP TABLE IF EXISTS; these tables exist in the 6.1 schema. +drop table autoping; +drop table pingqueueentry; +drop table pingtarget; +#else +#dropTableIfExists('autoping') Review Comment: 🤖Claude: fixed by replacing the Derby-only branch and the `#dropTableIfExists` calls with plain `drop table autoping; drop table pingqueueentry; drop table pingtarget;` for every database, with a comment saying why. The generated 610-to-700 scripts for derby, postgresql, mysql, oracle, db2, mssql and hsqldb now contain only those three statements and the two deletes. DatabaseInstallerUpgradeTest passes (7 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
