snoopdave commented on code in PR #298:
URL: https://github.com/apache/roller/pull/298#discussion_r4592362308
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java:
##########
@@ -247,6 +248,25 @@ public String getText(String key, String defaultValue,
String[] args) {
return super.getText(cleanTextKey(key), cleanTextKey(defaultValue),
cleanedArgs);
}
+ // used by the <s:text> tag for its <s:param> values
+ @Override
+ public String getText(String key, String defaultValue, List<?> args,
ValueStack stack) {
Review Comment:
🐞Claude Issue: **Important:** On master, `Bookmarks.jsp` and
`Categories.jsp` (not changed here) have about 15 `<s:text escapeHtml="true">`
tags with string `<s:param>` values, for example `<s:param
value="plainText(folder.name)"/>` and `<s:param value='#category.name'/>`. With
this override the parameter is escaped once here and again by the tag, so a
blogroll or category named `Q&A` shows as `Q&A` in those aria-labels,
titles and delete messages. `JspOutputEncodingTest` doesn't catch this. Suggest
removing `escapeHtml="true"` from those `<s:text>` tags (or only where all
params are escaped here), and adding a check to the test that `<s:text
escapeHtml="true">` has no string `<s:param>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]