mraible commented on code in PR #298:
URL: https://github.com/apache/roller/pull/298#discussion_r4592633700


##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java:
##########
@@ -247,6 +248,25 @@ public String getText(String key, String defaultValue, 
String[] args) {
         return super.getText(cleanTextKey(key), cleanTextKey(defaultValue), 
cleanedArgs);
     }
 
+    // used by the <s:text> tag for its <s:param> values
+    @Override
+    public String getText(String key, String defaultValue, List<?> args, 
ValueStack stack) {

Review Comment:
   Thanks, good catch. Fixed in 47b1a841a: the 19 `<s:text escapeHtml="true">` 
tags with `<s:param>` in Bookmarks.jsp, Categories.jsp and MediaFileView.jsp no 
longer escape their output. Their messages are either in element content or 
contain no quotes. `JspOutputEncodingTest` now fails if any `<s:text 
escapeHtml="true">` contains an `<s:param>`; I checked that it fails on the 
previous JSPs. 6.1.x (#299) has no such tags.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to