mraible opened a new pull request, #313: URL: https://github.com/apache/roller/pull/313
- Feed requests for later pages of entries (`?page=N`) now get their own keys in the weblog feed cache and the site-wide cache, the way the page cache already does. The page number is added only after the first page, so existing keys don't change. - The `page` parameter of feed and page requests is kept between 0 and 10,000 when parsed (`WeblogRequest.parsePageNum`), so the pager offset computed from it stays in range. A missing or unparsable value means the first page. - `PageServlet` now skips the page cache only when the server sets the `skipCache` request attribute, as it does for forwarded comment posts. It no longer reads a `skipCache` query parameter, which nothing in Roller's templates, JSPs or docs uses. Tests: `WeblogFeedCacheKeyTest`, `PageParameterTest` and `PageServletCacheTest`. Four of their seven cases fail without the change. `mvn test` passes (756 tests). CHANGES entries for this and the related fixes will come in one PR, so these don't conflict with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
