mraible opened a new pull request, #322: URL: https://github.com/apache/roller/pull/322
Four smaller fixes, one commit each: - **OIDC identity on the profile and registration forms.** `Profile.save` keeps the stored `openIdUrl` (the OIDC `issuer#sub` Roller uses to find an account at OIDC login), `ProfileBean.copyTo` no longer writes it, `Register.save` no longer takes it from the form, and the hidden field is gone from `Profile.jsp`. Only Roller's OIDC code sets it now. Admin `UserEdit` is unchanged. Test: `FederatedIdentityFormTest`. - **Weblog membership.** Declining an invitation only removes a pending permission, and a weblog's only administrator can't resign from it (new message `yourWebsites.resign.lastAdmin`). Test: `WeblogMembershipTest`. - **LDAP comment authenticator.** The commenter's user name is escaped with `javax.naming.ldap.Rdn.escapeValue` before it goes into the bind DN. Test: new cases in `LdapCommentAuthenticatorTest`. - **Search.** The search query (`q`) is capped at 256 characters, without splitting a surrogate pair, in search and feed requests, and `SearchOperation` treats any runtime exception while parsing or searching as a query error: no results, a logged warning. Tests: `SearchMalformedQueryTest`, `SearchQueryLengthTest`. `mvn test` passes (771 tests), and the Playwright database-login suite passes (20 run, 3 OIDC tests skipped). Found while testing, not changed here: deleting a weblog or user leaves its pending invitations behind. CHANGES entries for this and the related fixes will come in one PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
