snoopdave commented on code in PR #322:
URL: https://github.com/apache/roller/pull/322#discussion_r4636770126


##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/Members.java:
##########
@@ -120,31 +127,40 @@ public String save() {
                 error = true;
             }
             // one iteration for each line (user) in the members table
+            Map<String, List<String>> changes = new LinkedHashMap<>();
             for (WeblogPermission perms : permsList) {
 
-                String sval = getParameter("perm-" + perms.getUser().getId());
+                User member = perms.getUser();

Review Comment:
   **Important:** `WeblogPermission.getUser()` uses an enabled-only lookup, so 
it returns null for a disabled member. `Members.jsp` still renders that 
permission with a blank user name and an editable radio group, but this 
`continue` ignores its submitted choice. Look up the user regardless of enabled 
status, or key the row by the permission, so an admin can remove or change it; 
add a page-action test for that case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to