mraible opened a new pull request, #345:
URL: https://github.com/apache/roller/pull/345

   Follows up #326 from review, with the same changes as the master follow-up 
to #314. Changes to the planet feed fetcher (`RomeFeedFetcher`):
   
   - An interrupted fetch restores the thread's interrupt flag before throwing 
`FetcherException`.
   - A malformed feed URL fails with a `FetcherException` instead of the 
`IllegalArgumentException` from `URI.create`.
   - A response other than 2xx fails with its status instead of being parsed as 
a feed.
   - On Java 11, cancelling the response future doesn't stop the exchange, so a 
stalled feed kept downloading after the fetcher gave up. The body subscriber 
now cancels its subscription when the fetcher stops waiting, which closes the 
connection.
   
   Tests: new `RomeFeedFetcherLimitsTest` cases cover an abandoned download 
being closed, a 404, a malformed URL and a kept interrupt. The timing tests 
allow more time, so a slow build machine doesn't fail them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to