I was going to ask Alex for some summarize cause I wanted to help with renaming at least from the Maven point of view. Where did you finished ? What's more is need to be done ?
Thanks, Piotr 2017-10-10 23:38 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>: > OK, looks like the build passed. I'm going to stop working on the rename > in order to investigate some AMF issues. Volunteers are welcome to > continue renaming stuff. > > -Alex > > On 10/10/17, 12:40 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote: > > >Hi Alex, > > > >I think we should skip and make the changes after rename. Let's not hold > >on > >this one. Do we have issue on github for that tests ? If yes let's move > >forward. > > > >Piotr > > > >2017-10-10 6:44 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>: > > > >> OK, it looks like I fixed the profile and pipeline so it builds the > >> utility jars. > >> > >> Now it is failing on the tests. Should we have the build skip tests for > >> now? Otherwise, we have to do a bunch of refactoring to break externC > >>out > >> so we can build the typedefs js.swc first, then use those classes in the > >> rewritten tests. > >> > >> It also appears that some tests may still be using the regular Flex SDK. > >> I think those tests should either be rewritten or moved to a profile. > >> > >> Thoughts? > >> -Alex > >> > >> On 10/8/17, 9:03 PM, "Alex Harui" <aha...@adobe.com.INVALID> wrote: > >> > >> >Hi Piotr, > >> > > >> >Yes, that's what I saw too. I will look into it more tomorrow (about > >>12 > >> >hours from now). > >> > > >> >-Alex > >> > > >> >On 10/8/17, 3:44 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > >>wrote: > >> > > >> >>Hi Alex, > >> >> > >> >>I just look into that and found some comments from Chris[1] [2]. Once > >>I > >> >>build first "compiler-jburg-types" compiler build fire up. Not sure > >>how > >> >>to > >> >>get it work on Jenkins. In one of the comment in code I see: > >> >> > >> >>"As the compiler needs artifacts that are part of this project, the > >>build > >> >> > >> >>will fail, if the utility artifacts compiler-build-tools or > >> >>compiler-jburg-types > >> >>haven't been built. We therefore have a utils profile, that builds > >>these > >> >>prerequisites. After one build with "-P utils" has been built, the > >> >>default > >> >>build should be able to do it's job." > >> >> > >> >> > >> >>[1] > >> >>https://na01.safelinks.protection.outlook.com/?url= > >> http%3A%2F%2Fapache-fl > >> >>e > >> >>x-development.2333347.n4.nabble.com%2FFalcon-Pre- > >> Release-work-td53815.htm > >> >>l > >> >>&data=02%7C01%7C%7C421b11a60a47424c0d7808d50e39 > >> 99ad%7Cfa7b1b5a7b34438794a > >> >>e > >> >>d2c178decee1%7C0%7C0%7C636430562913079338&sdata= > >> yeOyI234YtTUoVt7L%2FudvFY > >> >>P > >> >>bc4s%2Fk1goDve6f6bWMc%3D&reserved=0 > >> >>[2] > >> >>https://na01.safelinks.protection.outlook.com/?url= > >> http%3A%2F%2Fapache-fl > >> >>e > >> >>x-development.2333347.n4.nabble.com%2FDISCUSS-Discuss- > >> Release-Apache-Flex > >> >>- > >> >>FalconJX-0-7-0-RC1-tp54816p54837.html&data=02% > >> 7C01%7C%7C421b11a60a47424c0 > >> >>d > >> >>7808d50e3999ad%7Cfa7b1b5a7b34438794aed2c178de > >> cee1%7C0%7C0%7C6364305629130 > >> >>7 > >> >>9338&sdata=qiCErex3n5eUoGV3t3sU99CYKhhIBXNcgFl9mQvjtII%3D&reserved=0 > >> >> > >> >>Piotr > >> >> > >> >> > >> >>2017-10-07 8:45 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>: > >> >> > >> >>> I'm not planning to work on it this weekend. In the main > >> >>>royals-compiler > >> >>> pom.xml it talks about a "utils profile". I couldn't figure it out > >>so > >> >>>I > >> >>> built the projects manually when working locally. Maybe someone > >>else > >> >>>can > >> >>> figure out what to do with ASF Jenkins. > >> >>> > >> >>> -Alex > >> >>> > >> >>> On 10/6/17, 8:44 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > >> >>>wrote: > >> >>> > >> >>> >Hi Alex, > >> >>> > > >> >>> >I just switched on feature/rename branch on pipeline. It's failing > >> >>>right > >> >>> >now [1]. Maybe it will be helpful for farther work on renaming. > >> >>> > > >> >>> >[1] > >> >>> >https://na01.safelinks.protection.outlook.com/?url= > >> >>> https%3A%2F%2Fbuilds.ap > >> >>> >ache.org%2Fjob%2FRoyale%2520Pipeline%2Fjob%2Ffeature% > >> >>> 25252Frename%2F1%2F&d > >> >>> >ata=02%7C01%7C%7Ca1e701dded204133376f08d50d35 > >> >>> b845%7Cfa7b1b5a7b34438794aed2 > >> >>> >c178decee1%7C0%7C0%7C636429446739379284&sdata= > >> >>> LS4QjOtvEl1ZhpSdlHhEmjDAiL5K > >> >>> >Nmf1MR9YtOEI1ZM%3D&reserved=0 > >> >>> > > >> >>> >Piotr > >> >>> > >> >>> > >> >> > >> >> > >> >>-- > >> >> > >> >>Piotr Zarzycki > >> >> > >> >>mobile: +48 880 859 557 > >> >>skype: zarzycki10 > >> >> > >> >>LinkedIn: > >> >>https://na01.safelinks.protection.outlook.com/?url= > >> http%3A%2F%2Fwww.linke > >> >>d > >> >>in.com%2Fpiotrzarzycki&data=02%7C01%7C%7C421b11a60a47424c0d7808d50e39 > >> 99ad > >> >>% > >> >>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% > >> 7C636430562913079338&sdata=er6 > >> >>E > >> >>5Mp5htHyot7mEpwKKxxyYYrVbqRu7yxcU1uqs%2Fw%3D&reserved=0 > >> >><https://na01.safelinks.protection.outlook.com/?url= > >> https%3A%2F%2Fpl.link > >> >>e > >> >>din.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02% > >> 7C01%7C%7C421b11a60a47424c > >> >>0 > >> >>d7808d50e3999ad%7Cfa7b1b5a7b34438794aed2c178de > >> cee1%7C0%7C0%7C636430562913 > >> >>0 > >> >>79338&sdata=73Bj22JXvpZZaJoQLNBZ74eXtJzLph > BFv8Bb7GMtvos%3D&reserved=0> > >> >> > >> >>GitHub: > >> >>https://na01.safelinks.protection.outlook.com/?url= > >> https%3A%2F%2Fgithub.c > >> >>o > >> >>m%2Fpiotrzarzycki21&data=02%7C01%7C%7C421b11a60a47424c0d7808d50e39 > >> 99ad%7C > >> >>f > >> >>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636430562913079338&sdata= > >> g2e4K7 > >> >>B > >> >>jyK8%2F9Bytchrfr9jpgUXWWI1xX8cSeUT40f0%3D&reserved=0 > >> > > >> > >> > > > > > >-- > > > >Piotr Zarzycki > > > >mobile: +48 880 859 557 > >skype: zarzycki10 > > > >LinkedIn: > >https://na01.safelinks.protection.outlook.com/?url= > http%3A%2F%2Fwww.linked > >in.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cb00eb3ae041d4d5b5cde08d50fb2 > 345e% > >7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636432180408541412&sdata= > ymqr > >IKqv1q2DnSu%2Byex0lovpfo9nfegEkMo1JzIljDQ%3D&reserved=0 > ><https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fpl.linke > >din.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02% > 7C01%7C%7Cb00eb3ae041d4d5b5 > >cde08d50fb2345e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C6364321804085 > >41412&sdata=DM6JGlteIDa2NxrFTLYslmlqx3vFmhlleN6PceHhHeo%3D&reserved=0> > > > >GitHub: > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fpiotrzarzycki21&data=02%7C01%7C%7Cb00eb3ae041d4d5b5cde08d50fb2 > 345e%7Cf > >a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636432180408541412&sdata= > Df9EWe0 > >JdVEePN3VWlkExVhHyCYsaFl8dswouMYKTw8%3D&reserved=0 > > -- Piotr Zarzycki mobile: +48 880 859 557 skype: zarzycki10 LinkedIn: http://www.linkedin.com/piotrzarzycki <https://pl.linkedin.com/in/piotr-zarzycki-92a53552> GitHub: https://github.com/piotrzarzycki21
