On Wed, Dec 13, 2017 at 11:00 AM, Peter Ent <p...@adobe.com.invalid> wrote:
> I've pushed changes to the Slider component and resolved (I hope) most of > the issues listed below by Justin. Only one, having to do with arrow keys, > should be resolved or at least improved. The arrow keys should be > addressed by a keyboard controller bead. > > I included a VerticalSliderLayout as well as VSliderMouseController > (you'll need both to do vertical sliders). I may roll this into a VSlider > for Express. > > I also renamed SliderMouseController to HSliderMouseController to be > consistent. I checked other projects and found only Flat to have used that > directly. > > ‹peter > Thanks for fixing this, Peter. Just one request, in your commit message, if you include the issue number in this format: #99, it will link the commit with the issue. This will be very useful for tracking changes in future. Regards, Om > > On 12/12/17, 5:21 PM, "Justin Mclean" <jus...@classsoftware.com> wrote: > > >HI, > > > >A while back I raised several issues with the slider component, if you > >happen if fix any of these issues please close them. [1][2][3][4][5] > > > >I note for instance the slider still incorrectly gives the value NaN when > >you click on the track. > >The issue arises in this line in the calcValFromMousePosition method: > > > >var deltaX:Number = (useOffset ? event.offsetX : event.clientX) - origin; > > > >As when you click on the track offsetX is not contained in the event. > > > >A fix (in the PR) is to change the line to: > >var deltaX:Number = (event.offsetX && useOffset ? event.offsetX : > >event.clientX) - origin; > > > >I would normally use event.offsetX !== undefined rather than just > >event.offsetX but this project seems to have an aversion to using the > >strict equality / inequality operators. > > > >There may of course be other ways to fix this issue. > > > >Thanks, > >Justin > > > >1. > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fapache%2Froyale-asjs%2Fissues%2F86&data=02%7C01%7Cpent%40adobe.com > %7Cc > >1fc0a17ee274829d1d708d541aeb58e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0 > >%7C636487140985163005&sdata=JkssfIJkd4YohkXMZ0ZCy98hK6ok38 > S3KShzzVr4hQE%3D > >&reserved=0 > >2. > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fapache%2Froyale-asjs%2Fissues%2F84&data=02%7C01%7Cpent%40adobe.com > %7Cc > >1fc0a17ee274829d1d708d541aeb58e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0 > >%7C636487140985163005&sdata=s%2F83hm8ZBh5fIcPEMfbdmIliNYm6XV > u1ev%2BjHaQF%2 > >BNI%3D&reserved=0 > >3. > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fapache%2Froyale-asjs%2Fissues%2F83&data=02%7C01%7Cpent%40adobe.com > %7Cc > >1fc0a17ee274829d1d708d541aeb58e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0 > >%7C636487140985163005&sdata=bnFSx8JXgOHwGQpBbAfihAZpgYXw% > 2BJeqg%2F9y4sfKii > >w%3D&reserved=0 > >4. > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fapache%2Froyale-asjs%2Fissues%2F82&data=02%7C01%7Cpent%40adobe.com > %7Cc > >1fc0a17ee274829d1d708d541aeb58e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0 > >%7C636487140985163005&sdata=erh8n5SMNZB%2Ff% > 2FEKl0lxw3TS8wsFMzZ44e4GPxbYu7 > >I%3D&reserved=0 > >5. > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.co > >m%2Fapache%2Froyale-asjs%2Fissues%2F81&data=02%7C01%7Cpent%40adobe.com > %7Cc > >1fc0a17ee274829d1d708d541aeb58e%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0 > >%7C636487140985163005&sdata=kK2sjhS0r71MgTlE7VE2XGGA1q6DUX > irc%2B%2BH3Dh4d4 > >s%3D&reserved=0 > > > >
