I found that setting the environment variable PLAYERGLOBAL_VERSION seems to allow the build to work with a playerglobal other than 11.1. I updated the README for the following release.
-Alex On 1/9/18, 11:49 AM, "Alex Harui" <[email protected]> wrote: >I made some changes to the develop branch and tests seem to be passing on >Windows in the Maven CI > >-Alex > >On 1/9/18, 8:37 AM, "Alex Harui" <[email protected]> wrote: > >>FWIW, the tests passed for me on Windows on the first try, but the log >>shows I got lucky and the js.swc was written out after the second test >>started but must have just been in time for the compiler to see it. >> >>I will spend some time today to put in a better solution in the develop >>branch before turning tests on in the Maven CI. >> >>But whether Om changes his vote or not, if you vote +1 and I vote +1 and >>we get one more person to vote +1 we will have enough votes. IMO, the >>source package is "not illegal" and "better than the last release" mainly >>because there is no last release. >> >>My 2 cents, >>-Alex >> >>On 1/9/18, 3:28 AM, "Piotr Zarzycki" <[email protected]> wrote: >> >>>On pipeline tests are skipped. If Om will try again without clean and >>>have >>>same result as me - I think we are good here. >>> >>>Thanks, Piotr >>> >>>2018-01-09 10:35 GMT+01:00 Piotr Zarzycki <[email protected]>: >>> >>>> Alex, >>>> >>>> Yes they passed without the clean. :) >>>> >>>> Thanks, Piotr >>>> >>>> 2018-01-09 9:43 GMT+01:00 Alex Harui <[email protected]>: >>>> >>>>> I just found out that the royals-compiler build on builds.a.o was not >>>>> running tests. >>>>> >>>>> I'm running the approval script on Windows right now. I'll probably >>>>>go to >>>>> bed and check it in the morning. It passed on Mac for me. >>>>> >>>>> If you run Maven without a clean a second time on the royale-compiler >>>>> folder do the tests pass? >>>>> >>>>> -Alex >>>>> >>>>> On 1/9/18, 12:32 AM, "Piotr Zarzycki" <[email protected]> >>>>>wrote: >>>>> >>>>> >I dont remember at all when I run tests last time. Im always using >>>>> >builds.a.o for the tests. As you said if they pass on builds.a.o we >>>>>may >>>>> be >>>>> >good. Letès check on pipeline >>>>> > >>>>> >https://na01.safelinks.protection.outlook.com/?url=https% >>>>> 3A%2F%2Fbuilds.ap >>>>> >ache.org%2Fjob%2FRoyale%2520Pipeline%2Fjob%2Frelease%25252F >>>>> 0.9.0%2F&data=0 >>>>> >2%7C01%7Caharui%40adobe.com%7C405f516730bd43493ad408d5573b9 >>>>> 87e%7Cfa7b1b5a7 >>>>> >b34438794aed2c178decee1%7C0%7C0%7C636510835837943808&sdata= >>>>> iWcLbIQRQu%2Bm% >>>>> >2FNyqNz6jMoQR5%2FuRrnklHLsGRXQp7Q8%3D&reserved=0 >>>>> > >>>>> >Thanks, Piotr >>>>> > >>>>> >2018-01-09 9:22 GMT+01:00 Alex Harui <[email protected]>: >>>>> > >>>>> >> Last time you ran these tests from the repo or a nightly did they >>>>>pass? >>>>> >> >>>>> >> -Alex >>>>> >> >>>>> >> On 1/9/18, 12:18 AM, "Piotr Zarzycki" <[email protected]> >>>>> wrote: >>>>> >> >>>>> >> >Alex, >>>>> >> > >>>>> >> >I just run the tests and have same issue as Om. It is something >>>>>with >>>>> an >>>>> >> >order, cause tests first complaining about missing js.swc, later >>>>>that >>>>> >>swc >>>>> >> >is being written in the folder. [1] >>>>> >> > >>>>> >> >[1] >>>>> >> >https://na01.safelinks.protection.outlook.com/?url= >>>>> >> https%3A%2F%2Fpaste.apa >>>>> >> >che.org%2FwLFl&data=02%7C01%7Caharui%40adobe.com% >>>>> >> 7C736cd31637724aee40e808d >>>>> >> >557399276%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% >>>>> >> 7C636510827137224098& >>>>> >> >>>>>>sdata=tXmCRkO%2FdcEWd%2FQiibHIhOHTfKFXBMMaNnMy%2F8kcUsw%3D&reserved=0 >>>>> >> > >>>>> >> >Piotr >>>>> >> > >>>>> >> > >>>>> >> > >>>>> >> >2018-01-09 8:37 GMT+01:00 Alex Harui <[email protected]>: >>>>> >> > >>>>> >> >> >>>>> >> >> >>>>> >> >> On 1/8/18, 11:23 PM, "Piotr Zarzycki" >>>>><[email protected]> >>>>> >> wrote: >>>>> >> >> >>>>> >> >> >Alex, >>>>> >> >> > >>>>> >> >> >Agree with you for the tests with Maven Artifacts, but >>>>>definitely >>>>> >>I'm >>>>> >> >>with >>>>> >> >> >Om in case of failing tests. Unless there is some lot's of >>>>>fixes >>>>> >>there. >>>>> >> >> >>>>> >> >> A failing test may not be a major problem if it is only failing >>>>>for >>>>> a >>>>> >> >> minority of people and there is some workaround. It is >>>>>important to >>>>> >> >> understand how many people are affected by any particular >>>>>problem. >>>>> I >>>>> >> >> believe tests are passing on builds.a.o. They just passed for >>>>>me on >>>>> >>OS >>>>> >> >>X. >>>>> >> >> I will try myself on Windows tonight or tomorrow. Did those >>>>>tests >>>>> >>pass >>>>> >> >> for you? >>>>> >> >> >>>>> >> >> -Alex >>>>> >> >> >>>>> >> >> >>>>> >> > >>>>> >> > >>>>> >> >-- >>>>> >> > >>>>> >> >Piotr Zarzycki >>>>> >> > >>>>> >> >Patreon: >>>>> >> >*https://na01.safelinks.protection.outlook.com/?url= >>>>> >> https%3A%2F%2Fwww.patr >>>>> >> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com% >>>>> >> 7C736cd31637724a >>>>> >> >ee40e808d557399276%7Cfa7b1b5a7b34438794aed2c178de >>>>> >> cee1%7C0%7C0%7C6365108271 >>>>> >> >37224098&sdata=u%2BCwGcimIMkPro%2BJWlK2Fs6TYyO2BpqhqDgsd18lmrE >>>>> >> %3D&reserved >>>>> >> >=0 >>>>> >> ><https://na01.safelinks.protection.outlook.com/?url= >>>>> >> https%3A%2F%2Fwww.patr >>>>> >> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com% >>>>> >> 7C736cd31637724a >>>>> >> >ee40e808d557399276%7Cfa7b1b5a7b34438794aed2c178de >>>>> >> cee1%7C0%7C0%7C6365108271 >>>>> >> >37224098&sdata=u%2BCwGcimIMkPro%2BJWlK2Fs6TYyO2BpqhqDgsd18lmrE >>>>> >> %3D&reserved >>>>> >> >=0>* >>>>> >> >>>>> >> >>>>> > >>>>> > >>>>> >-- >>>>> > >>>>> >Piotr Zarzycki >>>>> > >>>>> >Patreon: >>>>> >*https://na01.safelinks.protection.outlook.com/?url=https% >>>>> 3A%2F%2Fwww.patr >>>>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7 >>>>> C405f516730bd43 >>>>> >493ad408d5573b987e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>>>> 7C0%7C6365108358 >>>>> >37943808&sdata=30yiv%2Fx%2B28u3sWUeKr%2FPscSqGdn2YoXMs1404Z >>>>> s4kfo%3D&reserv >>>>> >ed=0 >>>>> ><https://na01.safelinks.protection.outlook.com/?url=https% >>>>> 3A%2F%2Fwww.patr >>>>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7 >>>>> C405f516730bd43 >>>>> >493ad408d5573b987e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>>>> 7C0%7C6365108358 >>>>> >37943808&sdata=30yiv%2Fx%2B28u3sWUeKr%2FPscSqGdn2YoXMs1404Z >>>>> s4kfo%3D&reserv >>>>> >ed=0>* >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> Piotr Zarzycki >>>> >>>> Patreon: >>>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>>>a >>>>t >>>>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca39b009d23 >>>>2 >>>>f >>>>4bd54d0a08d557542dca%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651 >>>>0 >>>>9 >>>>41410823804&sdata=03hC1tELSgAZ5Kk0BsyuH50ZTEVAAeO6Gdm16CEumbs%3D&reserv >>>>e >>>>d >>>>=0 >>>> >>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>>>a >>>>t >>>>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca39b009d23 >>>>2 >>>>f >>>>4bd54d0a08d557542dca%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651 >>>>0 >>>>9 >>>>41410823804&sdata=03hC1tELSgAZ5Kk0BsyuH50ZTEVAAeO6Gdm16CEumbs%3D&reserv >>>>e >>>>d >>>>=0>* >>>> >>> >>> >>> >>>-- >>> >>>Piotr Zarzycki >>> >>>Patreon: >>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>t >>>r >>>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca39b009d232f >>>4 >>>b >>>d54d0a08d557542dca%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651094 >>>1 >>>4 >>>10823804&sdata=03hC1tELSgAZ5Kk0BsyuH50ZTEVAAeO6Gdm16CEumbs%3D&reserved=0 >>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>t >>>r >>>eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca39b009d232f >>>4 >>>b >>>d54d0a08d557542dca%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651094 >>>1 >>>4 >>>10823804&sdata=03hC1tELSgAZ5Kk0BsyuH50ZTEVAAeO6Gdm16CEumbs%3D&reserved=0 >>>> >>>* >> >
