Yes, you are correct. So I suppose it will be a migration issue. I'll be interested to see how prevalent it is "in the wild". If you have a public var with [Bindable], that should be ok and the Royale compiler will not warn on [Bindable] public vars. They are converted to getter/setters and thus are immune from minification. In theory most folks used public vars in Value Objects and made them [Bindable], but I have seen that folks just ignored the warning from the compiler that there was a binding to a non-bindable variable.
Thanks, -Alex On 2/20/18, 9:39 AM, "Andrew Wetmore" <[email protected]> wrote: >Am I right that public vars were no problem in apps compiled for Flash or >AIR use, and that this improvement relates to creating a Royale app for JS >production? > ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avas >t.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign% >3Dsig-email%26utm_content%3Dwebmail&data=02%7C01%7Caharui%40adobe.com%7C00 >be1125ff064036f91908d57888f3d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% >7C636547451960499643&sdata=srgB4g25gGyTHTw4CTBGloaYISc7TngykapuNBObECY%3D& >reserved=0> >Virus-free. >https://na01.safelinks.protection.outlook.com/?url=www.avast.com&data=02%7 >C01%7Caharui%40adobe.com%7C00be1125ff064036f91908d57888f3d8%7Cfa7b1b5a7b34 >438794aed2c178decee1%7C0%7C0%7C636547451960499643&sdata=2lJGLP%2FTb6jmmuot >pAciekV%2BV6R50G3XTYDq%2BctZMKQ%3D&reserved=0 ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avas >t.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign% >3Dsig-email%26utm_content%3Dwebmail&data=02%7C01%7Caharui%40adobe.com%7C00 >be1125ff064036f91908d57888f3d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% >7C636547451960499643&sdata=srgB4g25gGyTHTw4CTBGloaYISc7TngykapuNBObECY%3D& >reserved=0> ><#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > >On Tue, Feb 20, 2018 at 1:26 PM, Alex Harui <[email protected]> >wrote: > >> Hi, >> >> I just pushed compiler changes that will default to reporting a new >> warning if you have public var in your Royale code. Public methods, >> getters and setters are fine, but public vars do not handle >>minification. >> >> I also just pushed a sweep of the framework code to eliminate public var >> usage or add a directive to suppress the warning. At some point in >>time I >> will probably sweep the examples, but I'm letting it spit a few warnings >> for now. I hope to remove the * selector this week and that will >>require >> another sweep of the examples. >> >> Not using public vars should increase the changes that your minified >>code >> will run. I put some information about public var usage in the wiki. >>I'm >> not sure if or where it should go in the user doc. Users may be able >> survive with more public vars since it mainly matters for vars used in >> MXML, Binding, and States. But we want the framework to be clean, so if >> you see a warning from your framework code, please clean it up. >> >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c >>om%2Fapache%2Froyale-asjs%2Fwiki%2FPublic-Variables&data=02%7C01%7Caharui >>%40adobe.com%7C00be1125ff064036f91908d57888f3d8%7Cfa7b1b5a7b34438794aed2c >>178decee1%7C0%7C0%7C636547451960499643&sdata=NsEnVpwiOc9bR6TSbwJ%2FKmJLLs >>WvhMRN83uLj0JuK3A%3D&reserved=0 >> >> Thanks, >> -Alex >> >> > > >-- >Andrew Wetmore > >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14. >blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7C00be1125ff064036f91908 >d57888f3d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636547451960499643 >&sdata=7tfthDnaui6tpk0JIbAi3%2BN3JTELdLw%2Bgjo7Rf0o%2Fts%3D&reserved=0
