I must say that I was wrong in some part of my argumentation. I though the
problem was in UIBase setting up things like display:block, but after
looking at layout code since Harbs pointed me try to duplicate it by my
side I saw is the vertical layout what was setting the inline styles. For
that reason removing the display :block code I found in UIBase, doesn't
make effect (what makes me think what that code does really or if is dead
code, anyway something to look in the future).

So I tried to create my own layout in Jewel and only seeing what happen
commenting the part where the hardcoded is setup and change to a className

As a test I put the following rule in jewel.css

.vertical-layout-padding-gap {
    display: block !important;

and that work right :).

To make paddings and gap I think the right way is to separate in different
rules one for the vertical layout and others for padding, gap, and so,
using cascading, maybe I should use pseudo-selectors like :before and
:after for first and last elements.

In the end since Harbs thinks inline is right, and I'm in the opposite
thinking. I can make my own layouts for Jewel.
It's like CSS. basics I discussed in other thread, I think I'll not
affected by that since although I'm extending basic, I'm using my own class
selectors and html structure.

If you're all right with this I think we can go this way.

Let me know what do you think



2018-03-12 11:39 GMT+01:00 Carlos Rovira <carlosrov...@apache.org>:

> 2018-03-12 11:29 GMT+01:00 Harbs <harbs.li...@gmail.com>:
>> Can you explain why you care about inline CSS? I’m not getting it.
> As I get the basis of jewel and jewel theme working right, I want to start
> creating blog examples with the code and I know, people out there that
> wants to see if we are a option for their problems will look at the code we
> produce. If they see lots of styles hardcoded, my presumption is that will
> not had a good feeling about us and its one thing that can make us not be
> elegible us their technology of choice. I want to avoid that.
>> If find it much easier to understand inline CSS. It’s sometimes difficult
>> to figure out what sets specific inline styles, but it’s also difficult
>> sometimes to figure out what sets classes. Working through complex CSS
>> style sheets and figuring out which sheet is setting what style and why is
>> a *very* time consuming process. In my experience, style sheets makes
>> debugging more difficult and not easier.
> But that's where documentation comes in. If you see a clean html line
> where a button tag has organized semantic class like "jewel button primary
> vertical-layout", that's for me better than lots of styles there. Then in
> docs you can see that vertical-layout stands for
> .vertical-layout
> {
>     display: block;
> }
> for that's more clear. The html more leaner. Maybe as you point, the
> performance is not as good as inline, but don't think that will be enough
> to not consider all the benefits. In the end things goes to separate html
> from css, so I think that's the principal pattern and browser devs has in
> mind to get performant css.
> --
> Carlos Rovira
> http://about.me/carlosrovira

Carlos Rovira

Reply via email to