For me is ok. I think in this kind of things we should match Flex unless the way Flex behaves were proven wrong in this days. So +1 to Harbs changes.
@Harbs, can you make the changes in the alert branch and merge in develop? 2018-04-05 22:21 GMT+02:00 Piotr Zarzycki <[email protected]>: > Hi Carlos, > > I also looked into that. Changing orders in the "show" method is ok to me, > but I agree with Harbs. Why are we suggesting anything in the CloseEvent? > It should be -1 as default. No suggestion at all! > > Thanks, > Piotr > > 2018-04-04 14:31 GMT+02:00 Harbs <[email protected]>: > > > On second thought, why is the default not the same as the Flex version > > (i.e. -1) Why does there need to be a valid default value? > > > > I’d also suggest switching the order of the arguments on the CloseEvent. > I > > think detail should be the second argument. I can’t think of a really > good > > reason to specify bubbles and cancelable in Royale. > > > > Harbs > > > > > On Apr 4, 2018, at 1:52 PM, Carlos Rovira <[email protected]> > > wrote: > > > > > > Hi Harbs, > > > > > > my understanding is that windows use to have a top-right X button to > > close, > > > and that use to indicate that the user wants to close the window (a.k.a > > > cancel) without do anything the window want the user to do (a.k.a ok). > To > > > express an ok, the window or alert, use to have a button that express > > some > > > ok action so the user can clearly know what he/she is doing pressing > that > > > button. > > > > > > That's why I'm proposing this. > > > > > > I understand from your email that you're ok with the alert signature > > change > > > > > > Thanks > > > > > > Carlos > > > > > > > > > > > > > > > 2018-04-04 12:25 GMT+02:00 Harbs <[email protected]>: > > > > > >> I don’t think it’s appropriate to make cancel the default value in a > > close > > >> event. > > >> > > >>> On Apr 4, 2018, at 12:14 PM, Carlos Rovira <[email protected]> > > >> wrote: > > >>> > > >>> Hi, > > >>> > > >>> I uploaded few days ago the changes exposed here in a branch > > >>> ("feature/alert-changes") > > >>> Could someone review in order to see if we can merge it in develop? > > >>> > > >>> thanks > > >>> > > >>> > > >>> > > >>> ---------- Forwarded message ---------- > > >>> From: Carlos Rovira <[email protected]> > > >>> Date: 2018-03-31 23:34 GMT+02:00 > > >>> Subject: [Jewel] Alert look screenshot > > >>> To: [email protected] > > >>> > > >>> > > >>> *A note about Basic Alert: *I think we should change Basic to match > > this > > >>> since the all parameters except the last are in the same order as > Flex, > > >>> while Alert in Basic changes this order. As well CloseEvent default > > flag > > >> is > > >>> for OK, but I think it should match CANCEL. If you agree in make this > > two > > >>> changes to Basic I can do that. I can make a commit in a develop > branch > > >>> before do this and if you agree merge with develop > > >>> > > >>> > > >>> > > >>> -- > > >>> Carlos Rovira > > >>> http://about.me/carlosrovira > > >> > > >> > > > > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira > > > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
