Right, I think Alex found that source maps are on maven but not in ant and just was asking if add to ant or not. But don't think is blocking him
El dom., 26 may. 2019 a las 13:17, Piotr Zarzycki (< [email protected]>) escribió: > If there is no difference for IDE where source map is placed - Let's do > what is easier to do. It seems to be not a high priority stuff - unless it > is blocking Alex from moving forward. > > On Sun, May 26, 2019, 12:11 PM Carlos Rovira <[email protected]> > wrote: > > > Hi Piotr, > > > > yes, you can debug in IDE or Browser and reach to framework classes what > is > > great and very convenient. > > I think having both options would be best too, but as always someone > should > > add the switcher to do that. > > We always can do that at some time, but If there's no time at this > moment, > > I'll prefer source maps included by default and then > > wait for someone that want to add the switch. IOW, I prefer it as an > > "opt-out", since asume users will want this by default. > > > > El dom., 26 may. 2019 a las 10:04, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > Hi Carlos, > > > > > > When you build application by Maven - did you try it run by VSCode - > does > > > debugging working with build in source map? > > > I'm wondering how IDE would be influenced by having source map in/out > of > > > SWC. > > > > > > I think having both possibilities would be the best. > > > > > > Thanks, > > > Piotr > > > > > > On Sun, May 26, 2019, 8:26 AM Carlos Rovira <[email protected]> > > > wrote: > > > > > > > Hi, > > > > > > > > my opinion on this is that users'll want the capability to debug > > > framework > > > > code by default and will prefer that to save bandwidth. > > > > sourceMaps is other thing that differentiate Royale over many JS > basic > > > > libraries that does not have this built in and put us with the group > > that > > > > have it, so more in the group of "structured programing with > debugging > > > > capabilities". > > > > So I think ANT should have as well sourceMaps on by default. Then if > we > > > can > > > > have a switch for opt-out will be great, but maybe a bit of work for > > > > something that probably will be low priority right now, or we could > > wait > > > to > > > > someone to ask for, fill an issue and then work on it. > > > > About sourceRoot not mapping to anything, can't say since I thought > > that > > > > was not possible until now, so maybe others could respond to that > > > > thanks > > > > > > > > El dom., 26 may. 2019 a las 5:23, Alex Harui > (<[email protected] > > > >) > > > > escribió: > > > > > > > > > Hi, > > > > > > > > > > In working through the release automation, it appears that the > Maven > > > > build > > > > > puts source maps in the SWC for every JS file but the Ant build > does > > > not. > > > > > Should there be source maps in the SWCs? How do they work when the > > > > > sourceRoot doesn't map to anything? Or should that only be an > option > > > > when > > > > > building everything from sources on your machine? It would save a > > lot > > > in > > > > > terms of SWC size to not have source maps in the SWCs. > > > > > > > > > > Thoughts? > > > > > -Alex > > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > -- Carlos Rovira http://about.me/carlosrovira
