Hi Alex, ok, this is something we can look into it later. Is more important to get release process success without this
thanks! El dom., 26 may. 2019 a las 21:04, Alex Harui (<[email protected]>) escribió: > In my testing, sourcemaps built on other machines do not work on my local > machine, so I am going to skip generating them in our release artifacts. > > -Alex > > On 5/26/19, 10:03 AM, "Alex Harui" <[email protected]> wrote: > > I’m trying to understand whether SourceMaps built on another computer > actually work or not because the sourceRoot entry is different on each > machine. This is a problem for the release automation because we'd like > the SWCs to binary match regardless of which machine a SWC is built on. > Some possibilities: > > 1) They don't work if the sourceRoot does not match your file system. > 2) The browser will ask for a valid sourceRoot if the one supplied is > invalid > 3) We should be hosting sourcemaps on a server. > > In searching the internet, it appears that sourceRoot is optional and > can be null, so I might try that first, but other articles are about > incorrect sourceRoot paths. Yet other articles mention using URLs instead > of local relative paths. > > So, it could turn out that sourcemaps in SWCs are only useful when you > build from sources on your machine so all of the paths are correct. If > that's true, then when building release artifacts I'm going to turn off > source map generation. If sourceRoot can be null, then we will add > sourcemaps to the Ant build. Separately, if someone wants to take on using > URLs and figuring out a scheme for us to host them, that's fine as well. > > I was hoping someone had already tried it and knew the answer, but > apparently I will have to take the time to do the investigation myself. > > Thanks, > -Alex > > On 5/26/19, 7:04 AM, "Piotr Zarzycki" <[email protected]> > wrote: > > Carlos, > > Alex in his original email is saying: "....it appears that the > Maven build > puts source maps in the SWC for every JS file but the Ant build > does not." > - How are you understand that ? > > niedz., 26 maj 2019 o 15:50 Carlos Rovira <[email protected] > > > napisał(a): > > > Hi Piotr, > > > > don't understand what you say. > > *.js files has a separate *.map.js > > but IDES use to folder this file as part of the .js > > > > El dom., 26 may. 2019 a las 14:07, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > Now you confuses me - I understand that both build system > produce source > > > map. However in case of Maven source map is not an separate > file, but it > > is > > > part of SWC. - Do you understand it the same ? > > > > > > On Sun, May 26, 2019, 1:42 PM Carlos Rovira < > [email protected]> > > > wrote: > > > > > > > Right, I think Alex found that source maps are on maven but > not in ant > > > and > > > > just was asking if add to ant or not. But don't think is > blocking him > > > > > > > > El dom., 26 may. 2019 a las 13:17, Piotr Zarzycki (< > > > > [email protected]>) escribió: > > > > > > > > > If there is no difference for IDE where source map is > placed - Let's > > do > > > > > what is easier to do. It seems to be not a high priority > stuff - > > unless > > > > it > > > > > is blocking Alex from moving forward. > > > > > > > > > > On Sun, May 26, 2019, 12:11 PM Carlos Rovira < > > [email protected]> > > > > > wrote: > > > > > > > > > > > Hi Piotr, > > > > > > > > > > > > yes, you can debug in IDE or Browser and reach to > framework classes > > > > what > > > > > is > > > > > > great and very convenient. > > > > > > I think having both options would be best too, but as > always > > someone > > > > > should > > > > > > add the switcher to do that. > > > > > > We always can do that at some time, but If there's no > time at this > > > > > moment, > > > > > > I'll prefer source maps included by default and then > > > > > > wait for someone that want to add the switch. IOW, I > prefer it as > > an > > > > > > "opt-out", since asume users will want this by default. > > > > > > > > > > > > El dom., 26 may. 2019 a las 10:04, Piotr Zarzycki (< > > > > > > [email protected]>) escribió: > > > > > > > > > > > > > Hi Carlos, > > > > > > > > > > > > > > When you build application by Maven - did you try it > run by > > VSCode > > > - > > > > > does > > > > > > > debugging working with build in source map? > > > > > > > I'm wondering how IDE would be influenced by having > source map > > > in/out > > > > > of > > > > > > > SWC. > > > > > > > > > > > > > > I think having both possibilities would be the best. > > > > > > > > > > > > > > Thanks, > > > > > > > Piotr > > > > > > > > > > > > > > On Sun, May 26, 2019, 8:26 AM Carlos Rovira < > > > [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > my opinion on this is that users'll want the > capability to > > debug > > > > > > > framework > > > > > > > > code by default and will prefer that to save > bandwidth. > > > > > > > > sourceMaps is other thing that differentiate Royale > over many > > JS > > > > > basic > > > > > > > > libraries that does not have this built in and put > us with the > > > > group > > > > > > that > > > > > > > > have it, so more in the group of "structured > programing with > > > > > debugging > > > > > > > > capabilities". > > > > > > > > So I think ANT should have as well sourceMaps on by > default. > > Then > > > > if > > > > > we > > > > > > > can > > > > > > > > have a switch for opt-out will be great, but maybe a > bit of > > work > > > > for > > > > > > > > something that probably will be low priority right > now, or we > > > could > > > > > > wait > > > > > > > to > > > > > > > > someone to ask for, fill an issue and then work on > it. > > > > > > > > About sourceRoot not mapping to anything, can't say > since I > > > thought > > > > > > that > > > > > > > > was not possible until now, so maybe others could > respond to > > that > > > > > > > > thanks > > > > > > > > > > > > > > > > El dom., 26 may. 2019 a las 5:23, Alex Harui > > > > > (<[email protected] > > > > > > > >) > > > > > > > > escribió: > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > In working through the release automation, it > appears that > > the > > > > > Maven > > > > > > > > build > > > > > > > > > puts source maps in the SWC for every JS file but > the Ant > > build > > > > > does > > > > > > > not. > > > > > > > > > Should there be source maps in the SWCs? How do > they work > > when > > > > the > > > > > > > > > sourceRoot doesn't map to anything? Or should > that only be > > an > > > > > option > > > > > > > > when > > > > > > > > > building everything from sources on your machine? > It would > > > save > > > > a > > > > > > lot > > > > > > > in > > > > > > > > > terms of SWC size to not have source maps in the > SWCs. > > > > > > > > > > > > > > > > > > Thoughts? > > > > > > > > > -Alex > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Carlos Rovira > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=3jAh7mK3lBMMGBYkH9ob1BFgy6rlaWvEnR1gY8Z2aVQ%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=3jAh7mK3lBMMGBYkH9ob1BFgy6rlaWvEnR1gY8Z2aVQ%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=3jAh7mK3lBMMGBYkH9ob1BFgy6rlaWvEnR1gY8Z2aVQ%3D&reserved=0 > > > > > > > > > > > > > -- > > Carlos Rovira > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=3jAh7mK3lBMMGBYkH9ob1BFgy6rlaWvEnR1gY8Z2aVQ%3D&reserved=0 > > > > > -- > > Piotr Zarzycki > > Patreon: * > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=AxJ8cBBa3eXAFhbA2eW343YTgzvHaRHqWzCq%2FYEZvCo%3D&reserved=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C2b817ced6b8b475a8d1a08d6e1fc0bcd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636944870022195738&sdata=AxJ8cBBa3eXAFhbA2eW343YTgzvHaRHqWzCq%2FYEZvCo%3D&reserved=0 > >* > > > > > -- Carlos Rovira http://about.me/carlosrovira
