I’m really not excited about the use of inject_html in Framework code.
> On Jul 9, 2019, at 7:13 PM, Carlos Rovira <carlosrov...@apache.org> wrote: > > Hi Alex, > > El mar., 9 jul. 2019 a las 17:43, Alex Harui (<aha...@adobe.com.invalid > <mailto:aha...@adobe.com.invalid>>) > escribió: > >> IMO, adding an API for missing.js should only be done for APIs that are >> truly cross-browser. If an API requires a polyfill, then if we add it to >> missing.js and someone tries to use it on the browser that doesn't support >> it, it won't work for them without the polyfill. >> > > ok. another option could be to provide the inject_html for the polyfill if > the user uses "animate" method, since the polyfill makes that > cross-browser. This is other abstraction or ease of development for Royal > users. > > >> >> Either there should be a separate typedefs SWC for it, or we should see >> what changes to the toolchain are needed to allow the missing API to be >> supplied by a source extern in the SWC that uses it. >> > > I don't understand exactly what you propose here. I think I miss some > knowledge here. > > thanks > > > >> >> My 2 cents, >> -Alex >> >> On 7/9/19, 7:57 AM, "Josh Tynjala" <joshtynj...@bowlerhat.dev> wrote: >> >> Generally, if we need a browser API that Closure doesn't include in >> it's >> official externs, we add it to missing.js in the appropriate library in >> royale-typedefs. >> >> - Josh >> >> On Tue, Jul 9, 2019, 4:39 AM Piotr Zarzycki <piotrzarzyck...@gmail.com >>> >> wrote: >> >>> I thought this is the right place, from where I should download it >> to have >>> URLSearchParams available ? >>> >>> wt., 9 lip 2019 o 13:33 Harbs <harbs.li...@gmail.com> napisał(a): >>> >>>> I see you added that line. It does not look like url.js was >> modified in >>>> royale-extras. Why are you downloading it from there? >>>> >>>>> On Jul 9, 2019, at 2:26 PM, Piotr Zarzycki < >> piotrzarzyck...@gmail.com> >>>> wrote: >>>>> >>>>> Hi Harbs, >>>>> >>>>> Unfortunately I don't see different. externc-config.xml has >> url.js in >>>>> target/downloads/browser/url.js. >>>>> Ant build is downloading url.js to that folder [2]. Maven build >> is >>> doing >>>>> exactly the same [3]. >>>>> >>>>> What am I missing ? >>>>> >>>>> [1] >>>>> >>>> >>> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fsrc%2Fmain%2Fconfig%2Fexternc-config.xml%23L89&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484735244&sdata=10jV0FoSeRbDPa2Ex7Vj6ivI%2BR6hw5w47QPtbbNtPQI%3D&reserved=0 >>>>> [2] >>>>> >>>> >>> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fbuild.xml%23L116&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484735244&sdata=5yby%2B%2BSp4SM96q4BD5kzT8o7pIHyb%2Fo0nRP0HrVP1zs%3D&reserved=0 >>>>> [3] >>>>> >>>> >>> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fpom.xml%23L192&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484735244&sdata=lzI4EiTN90jLN5xZtM2TrO7PoowSb5WYYeYC%2FQfMp%2Fk%3D&reserved=0 >>>>> >>>>> Thanks, >>>>> Piotr >>>>> >>>>> wt., 9 lip 2019 o 11:06 Harbs <harbs.li...@gmail.com> >> napisał(a): >>>>> >>>>>> Take a look at the following files in the typedef repo: >>>>>> Lines 108-166 in build.xml >>>>>> Line 67 and later in pom.xml >>>>>> Notice the different paths in externc-config.xml >>>>>> >>>>>>> On Jul 9, 2019, at 11:57 AM, Carlos Rovira < >> carlosrov...@apache.org> >>>>>> wrote: >>>>>>> >>>>>>> So I can add Web Animations API externs there, but this will >> trigger >>>> some >>>>>>> build in extras and royale will pick that in the next build? >> I'm >>>> figuring >>>>>>> if something must be done I extras or just committing there is >> all >>> that >>>>>> is >>>>>>> needed >>>>>> >>>>>> >>>>> >>>>> -- >>>>> >>>>> Piotr Zarzycki >>>>> >>>>> Patreon: * >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484745236&sdata=0BTXcAQnVzT1EnfJouy0wZZwf4jdYCJm6tZheC0xYCI%3D&reserved=0 >>>>> < >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484745236&sdata=0BTXcAQnVzT1EnfJouy0wZZwf4jdYCJm6tZheC0xYCI%3D&reserved=0 >>> * >>>> >>>> >>> >>> -- >>> >>> Piotr Zarzycki >>> >>> Patreon: * >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484745236&sdata=0BTXcAQnVzT1EnfJouy0wZZwf4jdYCJm6tZheC0xYCI%3D&reserved=0 >>> < >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc47e32b453da4ca1ea1f08d7047dc0d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982810484745236&sdata=0BTXcAQnVzT1EnfJouy0wZZwf4jdYCJm6tZheC0xYCI%3D&reserved=0 >>> * >>> >> >> >> > > -- > Carlos Rovira > http://about.me/carlosrovira <http://about.me/carlosrovira>
