Would it be acceptable to include some sort of explanation that compiling from source will require setting a number of environment variables, not just ANT_HOME, and that, if you really want to compile 0.9.6 from source, you should contact [LIST EMAIL] for instructions on what to do? It sort of dodges the issue, but permits moving forward with the release with the presumption that, as Alex says, most people will want and use the compiled binaries.
I guess I would rather acknowledge the problem than look like we don't realize there is a problem. Andrew On Fri, Sep 20, 2019 at 2:10 AM Alex Harui <aha...@adobe.com.invalid> wrote: > I think we all want to get a release out. > > My user experience was the equivalent of taking the source package and > trying to build it without setting any environment variables other than > ANT_HOME as specified in the README. It did not work for me. > > The question is: how many of our users are going to try to build the > source package? And when it fails and the ask about it, will it bother > them to be told to go get the Adobe stuff and set environment variables? I > think it is a small number of people, almost everyone else is going to grab > binaries. However, it is bothering me because we are an open source > project and our minimum configuration should work but doesn't. > > -Alex > > On 9/19/19, 9:20 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote: > > I'm in favor of moving forward. I would like to finally release stuff. > > I can live with setting up env. Variables. I'm concern by the user > experience than mine. > > Thanks, > Piotr > > On Thu, Sep 19, 2019, 10:36 PM Alex Harui <aha...@adobe.com.invalid> > wrote: > > > Don't know. Judgement call. > > > > We've done a bunch of work since 0.9.4 to allow folks to be able to > > compile without the Adobe Flash and AIR SDKs. I've run into a > couple of > > problems. ASDoc's JSON generator was failing if you didn't have > Flash > > SDK. I mentioned it in the RC1 discuss thread. I think because it > is only > > this one example it is probably ok. > > > > What is less ok is another commit I have pending which is that the > main > > SWC build fails if you don't have Flash and AIR SDKs. In theory, > none of > > you should have been able to get the build to work without > environment > > variables for the Adobe stuff. So it depends a bit on how important > we > > think building from sources without the Adobe stuff is for this > release. > > If you did get the build to work without the Adobe stuff, check your > > environment and post the console output. I was fooled by having a > > PLAYERGLOBAL_HOME still set. When I took it away, more things broke. > > > > I'm testing building with Flash/AIR now to try to make sure my > js-only > > changes didn't affect js-swf. > > > > -Alex > > > > On 9/19/19, 1:19 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > wrote: > > > > Hi Alex, > > > > We need to have it in 0.9.6? > > > > Thanks, > > Piotr > > > > On Thu, Sep 19, 2019, 9:49 PM <aha...@apache.org> wrote: > > > > > This is an automated email from the ASF dual-hosted git > repository. > > > > > > aharui pushed a commit to branch release/0.9.6 > > > in repository > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C0c98322e88ba48a1b80e08d73d81d93f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045500251094592&sdata=mnsURL1gMlxcfmcHp2cC4j%2FEcp18AbP0lMakTFj0nKw%3D&reserved=0 > > > > > > > > > The following commit(s) were added to refs/heads/release/0.9.6 > by > > this > > > push: > > > new 55f3786 fix ASDoc js-only > > > 55f3786 is described below > > > > > > commit 55f37864c2a1b58b00eb41bad9ae2a9c121a6c6e > > > Author: Alex Harui <aha...@apache.org> > > > AuthorDate: Thu Sep 19 11:19:28 2019 -0700 > > > > > > fix ASDoc js-only > > > --- > > > .../ASDoc/src/main/config/asdoc-js-config.xml | 41 > > > +++++++++++++++++++++- > > > 1 file changed, 40 insertions(+), 1 deletion(-) > > > > > > diff --git > > a/examples/royale/ASDoc/src/main/config/asdoc-js-config.xml > > > b/examples/royale/ASDoc/src/main/config/asdoc-js-config.xml > > > index a720ac6..8fd00e5 100644 > > > --- a/examples/royale/ASDoc/src/main/config/asdoc-js-config.xml > > > +++ b/examples/royale/ASDoc/src/main/config/asdoc-js-config.xml > > > @@ -141,7 +141,7 @@ > > > > > > <!-- List of SWC files or directories that contain SWC > files. > > --> > > > <library-path> > > > - > > > > > > <path-element>{playerglobalHome}/{targetPlayerMajorVersion}.{targetPlayerMinorVersion}</path-element> > > > + > > <path-element>${frameworks_dir}/js/libs/XMLJS.swc</path-element> > > > </library-path> > > > > > > <!-- namespace declaration for asdoc --> > > > @@ -537,6 +537,8 @@ > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/ITextFieldView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/ImageAndTextButtonView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/CheckBoxView.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/CloseButtonView.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/ControlBarMeasurementBead.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/CSSButtonView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/CSSTextButtonView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/CSSToggleButtonView.as</path-element> > > > @@ -558,6 +560,8 @@ > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/HScrollBarTrackView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/VRuleView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/HRuleView.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/SolidBackgroundBead.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/SolidBackgroundWithChangeListenerBead.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/TextInputView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/TextInputWithBorderView.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/TextAreaView.as</path-element> > > > @@ -572,6 +576,41 @@ > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/VScrollBar.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/HScrollBar.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/ScrollBar.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ButtonAutoRepeatController.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/DropDownListController.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/TextFieldItemRenderer.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/VScrollBar.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/HScrollBar.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Basic/src/main/royale/org/apache/royale/html/supportClasses/ScrollBar.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/CSSShape.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/CSSSprite.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/IBorderModel.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/StageProxy.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/StyleableCSSTextField.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/WrappedMovieClip.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/WrappedShape.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/WrappedSprite.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/WrappedTextField.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/core/UIButtonBase.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/utils/CSSBorderUtils.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/utils/PNGEncoder.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/utils/SolidBorderUtil.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Core/src/main/royale/org/apache/royale/utils/dbg/DOMPathUtil.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/AdvancedLayoutFeatures.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/CompoundTransform.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/IAssetLayoutFeatures.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/MatrixUtil.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/PathHelper.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/TransformOffsets.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/ColorShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/ColorBurnShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/ColorDodgeShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/ExclusionShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/HueShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/LuminosityShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/LuminosityMaskShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/SaturationShader.as</path-element> > > > + > > > > > > <path-element>${frameworks_dir}/projects/Graphics/src/main/royale/org/apache/royale/graphics/utils/shaderClasses/SoftLightShader.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/scrollbar/VScrollBar.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/scrollbar/HScrollBar.as</path-element> > > > > > > > > > <path-element>${frameworks_dir}/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/scrollbar/ScrollBar.as</path-element> > > > > > > > > > > > > > > > -- Andrew Wetmore http://cottage14.blogspot.com/
