I would expect that this change would cause clicking on the icon to fail. Royale_wrapper is used to find the component that owns the element that was clicked. If not, why not?
Thanks, -Alex On 10/21/19, 6:01 AM, "[email protected]" <[email protected]> wrote: This is an automated email from the ASF dual-hosted git repository. piotrz pushed a commit to branch develop in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C4e28d579788b41297fd808d75626bb1e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637072596658923892&sdata=ztUNLAJPjSVRgumISnPSO2CqQTLwRc%2BOJ00TwJrHZ%2F4%3D&reserved=0 The following commit(s) were added to refs/heads/develop by this push: new 6a24158 Spark CheckBox: Remove royale_wrapper for icon 6a24158 is described below commit 6a24158993b3e9ed791dce02e427d3132992f5ff Author: Piotr Zarzycki <[email protected]> AuthorDate: Mon Oct 21 15:00:16 2019 +0200 Spark CheckBox: Remove royale_wrapper for icon - It causes maximum stack overflow exception during size measurement (reference #479 ) --- .../projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as | 2 -- 1 file changed, 2 deletions(-) diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as index 3d11ffa..aa7b55d 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as @@ -342,8 +342,6 @@ public class CheckBox extends ToggleButtonBase element.appendChild(_icon.element); element.appendChild(document.createTextNode('')); - //positioner.style.position = 'relative'; - _icon.element.royale_wrapper = this; typeNames = 'CheckBox CheckBoxIcon';
