Then you will need to explain why the event handling code that uses royale_wrapper is not going to be invoked. Maybe there is no way to actually click on the icon (as opposed to the label next to the icon)?
If you look through the code, I believe we set royale_wrapper on just about every child element in every other component. Creating an exception must be justified. The actual solution (some sort of stack overflow) might be better prevented by detecting the 'loop' of calls. We do that in several places already, like the layouts. -Alex On 10/21/19, 9:10 AM, "Piotr Zarzycki" <[email protected]> wrote: I will investigate that tomorrow, but so far everything is working without this code. Thanks! pon., 21 paź 2019 o 18:05 Alex Harui <[email protected]> napisał(a): > I would expect that this change would cause clicking on the icon to fail. > Royale_wrapper is used to find the component that owns the element that > was clicked. If not, why not? > > Thanks, > -Alex > > On 10/21/19, 6:01 AM, "[email protected]" <[email protected]> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > piotrz pushed a commit to branch develop > in repository > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C2684b08f468d4f19473d08d756413103%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637072710302383350&sdata=mUjpHyP%2Batw5%2BkF%2Bhh%2Fta1PhDjHovAiu2yLXYNGZOy4%3D&reserved=0 > > > The following commit(s) were added to refs/heads/develop by this push: > new 6a24158 Spark CheckBox: Remove royale_wrapper for icon > 6a24158 is described below > > commit 6a24158993b3e9ed791dce02e427d3132992f5ff > Author: Piotr Zarzycki <[email protected]> > AuthorDate: Mon Oct 21 15:00:16 2019 +0200 > > Spark CheckBox: Remove royale_wrapper for icon > > - It causes maximum stack overflow exception during size > measurement (reference #479 ) > --- > > .../projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as | > 2 -- > 1 file changed, 2 deletions(-) > > diff --git > a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as > b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as > index 3d11ffa..aa7b55d 100644 > --- > a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as > +++ > b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/CheckBox.as > @@ -342,8 +342,6 @@ public class CheckBox extends ToggleButtonBase > element.appendChild(_icon.element); > > element.appendChild(document.createTextNode('')); > - //positioner.style.position = 'relative'; > - _icon.element.royale_wrapper = this; > > typeNames = 'CheckBox CheckBoxIcon'; > > > > > -- Piotr Zarzycki Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C2684b08f468d4f19473d08d756413103%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637072710302393343&sdata=JnS1xaxIUD2p%2FshjwUPhnX4%2F7XOLwg6LG%2FlcgR8zgjw%3D&reserved=0 <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C2684b08f468d4f19473d08d756413103%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637072710302393343&sdata=JnS1xaxIUD2p%2FshjwUPhnX4%2F7XOLwg6LG%2FlcgR8zgjw%3D&reserved=0>*
