Hi Alex, I have pushed implementation and described it here [1]. Take a look and let me know if it's ok. It doesn't work - I'm thinking that it may be some kind of compiler issue.
[1] https://github.com/apache/royale-asjs/issues/472#issuecomment-546701359 Thanks, Piotr wt., 22 paź 2019 o 19:31 Alex Harui <[email protected]> napisał(a): > The emulation is currently only promising to support public APIs. If it > turns out that lots of folks have subclasses that call makeRowsAndColumns > then we'll emulate it. > > I recommend trying to extend the labelField pattern in Basic. IMO, the > labelField pattern is: > -"labelField" property on top-level component (TLC) passes to model > -Factory passes labelField property from model to itemRenderer > -ItemRenderer decides what to do with labelFunction > > So, in keeping with PAYG, whenever we get around to supporting > labelFunction in Basic, we'd add a code to subclasses of the TLCs, the > models, the factories, and the item renderers. > > I think that's a different flow from Flex, but should be sufficient unless > folks are relying on labelFunction/labelField in the .text property of the > listData structures. If you run into that then we can discuss how to > emulate the listData structure. > > My 2 cents, > -Alex > > On 10/22/19, 4:15 AM, "Yishay Weiss" <[email protected]> wrote: > > In my opinion it’s easier and more elegant to add the missing > functionality in a bead (e.g. > DataItemRendererFactoryForICollectionViewAdvancedDataGridData ) rather than > reproduce Flex’s class hierarchy. The only reason to do the latter would be > to make code that depends on a particular class hierarchy (is operator, > casting) run correctly. > > My approach would be to add the functionality in a bead, but make that > bead reusable so that it can be referenced from AdvancedListBase in case > that’s necessary. > > I hope that makes sense. > > ________________________________ > From: Piotr Zarzycki <[email protected]> > Sent: Tuesday, October 22, 2019 12:48:52 PM > To: [email protected] <[email protected]> > Subject: Emulation of labelFunction in ADG > > Hi Guys, > > I'm working on fixing issue [1]. labelFunction wasn't emulated at all > so > I'm trying to figure out how to add that. > > I checked deeper Flex code and it looks like launching labelFunction is > starting to happen during row creation. There is > function makeRowsAndColumnsWithExtraRows in AdvancedListBase where > everything is starting. > > My question is - should I go and start copying code and classes to fill > that gap or rather place launching that formatting in > DataItemRendererFactoryForICollectionViewAdvancedDataGridData > where we are creating and setup renderer ? What is the general > approach. > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472&data=02%7C01%7Caharui%40adobe.com%7C81866a47138140d3835008d756e1363f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637073397586964113&sdata=DiTcgW5jBz59adYWGe4Ty4CshHN0U54feeiQXlpWf9E%3D&reserved=0 > > Thanks, > -- > > Piotr Zarzycki > > Patreon: * > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81866a47138140d3835008d756e1363f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637073397586964113&sdata=PSS0FLhD3teBWrX5vM4bQjezOyVZuaLeb2KfYhVswFE%3D&reserved=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81866a47138140d3835008d756e1363f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637073397586964113&sdata=PSS0FLhD3teBWrX5vM4bQjezOyVZuaLeb2KfYhVswFE%3D&reserved=0 > >* > > > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
