To this one from Alina's example -> https://paste.apache.org/uxwvf . I have attached full example in the issue.
pon., 28 paź 2019 o 19:29 Alex Harui <aha...@adobe.com.invalid> napisał(a): > I do not know what formatter you are referring to. > > On 10/28/19, 11:26 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > wrote: > > Hi Alex, > > It looks like now function is being called properly, but formatter > which is > declared in <fx:Declarations> is undefined. Probably we could make some > workaround, but from Alina's perspective it is a different story. I'm > wondering why it is undefined, since it is in Declarations... > > Thanks, > Piotr > > pon., 28 paź 2019 o 17:59 Alex Harui <aha...@adobe.com.invalid> > napisał(a): > > > I just pushed changes to the compiler that should generate the right > > output. Give it a try. > > > > -Alex > > > > On 10/28/19, 8:32 AM, "Alex Harui" <aha...@adobe.com.INVALID> wrote: > > > > I will try to fix the compiler. > > > > The only thing I saw in the commit that didn't look right was > > assigning the itemrenderer's data to the result of the > labelFunction. I > > don't think Flex ever replaced the data property, I think the text to > > display was computed elsewhere. > > > > -Alex > > > > On 10/28/19, 12:20 AM, "Piotr Zarzycki" < > piotrzarzyck...@gmail.com> > > wrote: > > > > Alex, > > > > Will you look into compiler issue ? > > > > pon., 28 paź 2019 o 07:58 Piotr Zarzycki < > > piotrzarzyck...@gmail.com> > > napisał(a): > > > > > What do you think about implementation ? Cause I would > like to > > merge it > > > this week, even if there is compiler issue. > > > > > > pon., 28 paź 2019 o 07:12 Alex Harui > <aha...@adobe.com.invalid> > > > napisał(a): > > > > > >> Yes, looks like the compiler is not handling attributes > of type > > Function > > >> in MXML correctly. > > >> > > >> On 10/27/19, 7:56 AM, "Piotr Zarzycki" < > > piotrzarzyck...@gmail.com> > > >> wrote: > > >> > > >> Hi Alex, > > >> > > >> I have pushed implementation and described it here > [1]. > > Take a look > > >> and let > > >> me know if it's ok. It doesn't work - I'm thinking > that it > > may be > > >> some kind > > >> of compiler issue. > > >> > > >> [1] > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472%23issuecomment-546701359&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626277499&sdata=%2BHFpUGJOtt%2Bj8uzHUSDzlOXD0VaAUCerGe9%2FVz9pg%2B8%3D&reserved=0 > > >> > > >> Thanks, > > >> Piotr > > >> > > >> wt., 22 paź 2019 o 19:31 Alex Harui > > <aha...@adobe.com.invalid> > > >> napisał(a): > > >> > > >> > The emulation is currently only promising to support > > public APIs. > > >> If it > > >> > turns out that lots of folks have subclasses that > call > > >> makeRowsAndColumns > > >> > then we'll emulate it. > > >> > > > >> > I recommend trying to extend the labelField pattern > in > > Basic. IMO, > > >> the > > >> > labelField pattern is: > > >> > -"labelField" property on top-level component (TLC) > > passes to model > > >> > -Factory passes labelField property from model to > > itemRenderer > > >> > -ItemRenderer decides what to do with labelFunction > > >> > > > >> > So, in keeping with PAYG, whenever we get around to > > supporting > > >> > labelFunction in Basic, we'd add a code to > subclasses of > > the TLCs, > > >> the > > >> > models, the factories, and the item renderers. > > >> > > > >> > I think that's a different flow from Flex, but > should be > > sufficient > > >> unless > > >> > folks are relying on labelFunction/labelField in the > > .text property > > >> of the > > >> > listData structures. If you run into that then we > can > > discuss how > > >> to > > >> > emulate the listData structure. > > >> > > > >> > My 2 cents, > > >> > -Alex > > >> > > > >> > On 10/22/19, 4:15 AM, "Yishay Weiss" < > > yishayj...@hotmail.com> > > >> wrote: > > >> > > > >> > In my opinion it’s easier and more elegant to > add the > > missing > > >> > functionality in a bead (e.g. > > >> > > > DataItemRendererFactoryForICollectionViewAdvancedDataGridData ) > > >> rather than > > >> > reproduce Flex’s class hierarchy. The only reason > to do > > the latter > > >> would be > > >> > to make code that depends on a particular class > hierarchy > > (is > > >> operator, > > >> > casting) run correctly. > > >> > > > >> > My approach would be to add the functionality > in a > > bead, but > > >> make that > > >> > bead reusable so that it can be referenced from > > AdvancedListBase in > > >> case > > >> > that’s necessary. > > >> > > > >> > I hope that makes sense. > > >> > > > >> > ________________________________ > > >> > From: Piotr Zarzycki <piotrzarzyck...@gmail.com > > > > >> > Sent: Tuesday, October 22, 2019 12:48:52 PM > > >> > To: dev@royale.apache.org < > dev@royale.apache.org> > > >> > Subject: Emulation of labelFunction in ADG > > >> > > > >> > Hi Guys, > > >> > > > >> > I'm working on fixing issue [1]. labelFunction > wasn't > > emulated > > >> at all > > >> > so > > >> > I'm trying to figure out how to add that. > > >> > > > >> > I checked deeper Flex code and it looks like > launching > > >> labelFunction is > > >> > starting to happen during row creation. There is > > >> > function makeRowsAndColumnsWithExtraRows in > > AdvancedListBase > > >> where > > >> > everything is starting. > > >> > > > >> > My question is - should I go and start copying > code > > and classes > > >> to fill > > >> > that gap or rather place launching that > formatting in > > >> > > > DataItemRendererFactoryForICollectionViewAdvancedDataGridData > > >> > where we are creating and setup renderer ? What > is > > the general > > >> > approach. > > >> > > > >> > [1] > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F472&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626277499&sdata=VhtE2sUigQs8rQXpe28phN0PEu%2FnDM4JKobkc3aUIrw%3D&reserved=0 > > >> > > > >> > Thanks, > > >> > -- > > >> > > > >> > Piotr Zarzycki > > >> > > > >> > Patreon: * > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626277499&sdata=jN%2B3AlZyCBCtvTxHu19QtGtPco4gSPpmzAqHiXKrZy0%3D&reserved=0 > > >> > < > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > >> > >* > > >> > > > >> > > > >> > > > >> > > >> -- > > >> > > >> Piotr Zarzycki > > >> > > >> Patreon: * > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > >> < > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > >> >* > > >> > > >> > > >> > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > >* > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > > >* > > > > > > > > > > > > -- > > Piotr Zarzycki > > Patreon: * > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbffee53d8d204dba3f6908d75bd44907%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637078839626287494&sdata=39G7bMKAO4fwQ58BF4ICLoIrggPBzdJUh353Nf7WgyY%3D&reserved=0 > >* > > > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
