The second commit I looked at is also huge so I will not be able to review it or any others right now.
The things I remember wondering about in the first commit I reviewed is: 1) changing of the timestamp options that ensured SWFs are reproducible 2) removal of JGit which is needed by the CI release steps. Maybe they are restored in other commits. -Alex On 11/15/19, 10:32 AM, "Alex Harui" <[email protected]> wrote: I've only reviewed one commit in one PR so far, but I think it will break the CI release steps. Also, IMO, 0.9.6 has reproducible Maven artifacts. Improvements and fixes are welcome. Who is going to verify that the CI release steps continue to work after these changes? -Alex On 11/15/19, 9:52 AM, "Carlos Rovira" <[email protected]> wrote: To all, about reproducible builds: possibly the most interesting thing of all this changes might be that now we should allow releasing Royale via Maven with the ability of creating reproducible builds. Ideally releasing a part of Royale is just a 2-3 step process: - royale-compiler: - mvn release:prepare -DautoversionSubmodules=true - mvn release:perform - royale-typedefs: - update the pom.xml: royale.compiler.version to the new released version - mvn release:prepare -DautoversionSubmodules=true - mvn release:perform - royale-asjs: - update the pom.xml: royale.compiler.version and royale.typedefs.version to the new released version - mvn release:prepare -DautoversionSubmodules=true - mvn release:perform This combined with all the past effort done by Alex and Piotr, should lower the suffering of doing a release :) Carlos El vie., 15 nov. 2019 a las 15:46, Carlos Rovira (<[email protected]>) escribió: > Great you like it Harbs! :) > > I forgot to mention that another effort in parallel is to release v1.0.0 > of "flex-sdk-converter-maven-extension" (located in Apache Flex utilities > repo), > so we can remove the need to add "-s settings-template.xml" to each line, > what will improve event more the build process by reducing verbosity :) > > > > > El vie., 15 nov. 2019 a las 14:03, Harbs (<[email protected]>) > escribió: > >> If it all works, sounds great to me! :-) (I’m not going to be able to >> test until sometime next week, but don’t wait for me.) >> >> Thanks to Chris for working on this! >> >> Harbs >> >> > On Nov 15, 2019, at 2:45 PM, Carlos Rovira <[email protected]> >> wrote: >> > >> > Hi, >> > >> > this days Chris Dutz has had the deference and detail of working on >> > improving Apache Royale Maven build by simplifying the scripts so we all >> > have less headaches with all this stuff that he knows and master so >> well. >> > I want to give a big thanks to Chris for investing his time in working >> on >> > this huge improvement that for sure will help all us when building >> royale >> > in the daily basis and as well when having to make a new release. >> > >> > So Chris created 3 PRs that are for each repo to test. >> > >> > I already tested it and simplify all greatly. >> > >> > Here the recipe for building everything including tests and UI tests >> and so >> > on: >> > >> > #!/bin/bash >> > >> > *export* >> FLASHPLAYER_DEBUGGER="/Users/christofer.dutz/Devtools/Adobe/Flash/FlashPlayer-32.0/Flash >> > Player.app/Contents/MacOS/Flash Player Debugger" >> > >> > *cd* royale-compiler >> > >> > ./mvnw install -s settings-template.xml >> > >> > *cd* ../royale-typedefs >> > >> > ./mvnw install -s settings-template.xml >> > >> > *cd* ../royale-asjs >> > >> > ./mvnw install -s settings-template.xml -P >> > with-examples,with-distribution,with-ui-testsuite,option-with-swf >> > -Dwebdriver.gecko.driver=/Users/christofer.dutz/Downloads/geckodriver >> > >> > *cd* .. >> > >> > >> > you can use mvn or mvnw that will install Maven if you don't have any >> > installed :) >> > >> > >> > >> > You probably need to adjust the paths to the FLASHPLAYER_DEBUGGER as >> well >> > as for the geckodriver >> > >> > (If you don’t want to execute the Selenium UI tests in Firefox, just >> omit >> > the “with-ui-testsuite” profile) >> > >> > (Noting that I should add a Firefox detection to my prerequisite check) >> > >> > >> > You should not need to have FLASHPLAYERGLOBAL_HOME and >> > FLASHPLAYERGLOBAL_VERSION >> > >> > >> > >> > The profiles: >> > >> > - *with-examples*: Well it builds the examples too >> > - *with-distribution*: It lets the build also build the distribution >> > (this part is still incomplete, since like today, it does not >> generate a >> > valid SDK, but I'll work on this with Chris this next week). >> > - *option-with-swf*: It also makes each module build the swf version >> > - *with-ui-testsuite*: It also builds the testsuite modules and runs >> the >> > integration-tests >> > >> > >> > This PRs also introduces many fixes like a SASS new version that handles >> > memory better (that was causing all process to hang when launching all >> in >> > one single instruction due to memory leaks). Please revise the PRs to >> read >> > about all the list of improvements in this update. >> > >> > So If nobody opposite, I'd like to merge this improvement in the next >> hours. >> > >> > Thanks! :) >> > >> > -- >> > Carlos Rovira >> > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1e5ebf7f7aa2429853a608d769fa242f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094395389616999&sdata=Pa3PfYoV1iaz4sh3Ucyo5%2FEiJvQYj3pcyFgwYTXnjCE%3D&reserved=0 >> >> > > -- > Carlos Rovira > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1e5ebf7f7aa2429853a608d769fa242f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094395389616999&sdata=Pa3PfYoV1iaz4sh3Ucyo5%2FEiJvQYj3pcyFgwYTXnjCE%3D&reserved=0 > > -- Carlos Rovira https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1e5ebf7f7aa2429853a608d769fa242f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094395389616999&sdata=Pa3PfYoV1iaz4sh3Ucyo5%2FEiJvQYj3pcyFgwYTXnjCE%3D&reserved=0
