Hi Alex, ok I think is a good idea. I'll merge it now, so we can try the following days and see any issue it can arise. Thanks
Carlos El sáb., 16 nov. 2019 a las 0:29, Alex Harui (<[email protected]>) escribió: > Well, you can always merge the PR and see if anything blows up and revert > if it does. The only things I saw so far will affect the release steps but > probably not the nightly builds. > > -Alex > > On 11/15/19, 12:21 PM, "Carlos Rovira" <[email protected]> wrote: > > Hi Alex, > > El vie., 15 nov. 2019 a las 20:48, Alex Harui > (<[email protected]>) > escribió: > > > Hi Carlos, > > > > If/When you decide to merge these PRs, please make sure you have > reserved > > time to fix anything it breaks in CI. > > > > Let me know if the following plan would fit your expectations: > > 1) If nobody find any problem with the actual PRs in the next few > days, I > can merge it. > 2) Plan a release between Dec, 10-15th with me as RM. Since I'm new to > the > process, I think as happened with Piotr, I'll need help from Piotr and > you > to be able to do it. > 3) Fix any issue we find, and even try to see if we the new > improvements > can add up to simplify the current process > > > > > > I thought we already had made the changes to build with Maven without > > Flash. > > > > The new process simplifies it so newcomers (and all of us) benefits > from > having less prerequisites in his machine (like less env vars required > for > example) so we should expect more people be successful to get royale > build > without problems in the process, also instructions to build are > simplified. > We don't need to do different instructions anymore for a clean > environment > and post first build, what seems to me a huge improvement. Also we use > the > new maven reproducible builds that are supported in the build system > from > some weeks now. > > I think this is our main objetive as a project to simplify as possible > to > make it more accesible for newcomers. > > > > > > I have some missing DG features to implement for Alina before I can > find > > time to review the PR commits because they are big so might be > several days. > > > > ok, let me know if you want me to wait to merge to your reviews. The > problem of this is that the PRs could turn invalid and Chris could not > be > available at that time and that could make this effort to be lost. So > that > could complicate this merge. My opinion is that if some of us test the > PRs > and get it working we should not stop the merge to be done, and then > over > this changes we can go over the new 0.9.7 release in 2-3 weeks fixing > any > CI issue we can find we me as RM and releasing a 0.9.7 in the process > too. > > Let me know what you think. > > Thanks > > Carlos > > > > > > > > -Alex > > > > On 11/15/19, 11:43 AM, "Carlos Rovira" <[email protected]> > wrote: > > > > Hi Alex, > > > > my plan was to be a RM at some point, so maybe this is a good > time to > > do it. > > I think we all agree that improvements and fixes will need other > ones > > in > > the CI release steps. Can be improvements without touching that > part > > too I > > think all the improvements are worth it the changes to CI > process. I > > expect > > mostly it will be simplified since now the maven process is > lighter. > > We have currently 2 clients migrating from Flex so maybe I'll > need some > > weeks to mange it, but I could start a 0.9.7 at some point during > > December. > > Let me know what you think. > > > > btw, something important to pay attention that I think didn't > describe > > well. enough in my previous emails: One of the changes was to > allow to > > build the compiler too without the need to have any Flash stuff > by not > > enabling the “option-with-swf” profile. So in general it should > be > > possible > > to build Royale completely without any Flash third party stuff > and to > > build > > it completely with all tests if you enable the “option-with-swf” > > dependency. > > > > > > El vie., 15 nov. 2019 a las 19:38, Alex Harui > > (<[email protected]>) > > escribió: > > > > > The second commit I looked at is also huge so I will not be > able to > > review > > > it or any others right now. > > > > > > The things I remember wondering about in the first commit I > reviewed > > is: > > > 1) changing of the timestamp options that ensured SWFs are > > reproducible > > > 2) removal of JGit which is needed by the CI release steps. > > > > > > Maybe they are restored in other commits. > > > > > > -Alex > > > > > > On 11/15/19, 10:32 AM, "Alex Harui" <[email protected]> > > wrote: > > > > > > I've only reviewed one commit in one PR so far, but I > think it > > will > > > break the CI release steps. > > > > > > Also, IMO, 0.9.6 has reproducible Maven artifacts. > > > > > > Improvements and fixes are welcome. Who is going to > verify that > > the > > > CI release steps continue to work after these changes? > > > > > > -Alex > > > > > > On 11/15/19, 9:52 AM, "Carlos Rovira" < > [email protected]> > > wrote: > > > > > > To all, about reproducible builds: > > > > > > > > > possibly the most interesting thing of all this changes > > might be > > > that now > > > we should allow releasing Royale via Maven with the > ability > > of > > > creating > > > reproducible builds. > > > > > > Ideally releasing a part of Royale is just a 2-3 step > > process: > > > > > > > > > > > > - royale-compiler: > > > - mvn release:prepare > -DautoversionSubmodules=true > > > - mvn release:perform > > > - royale-typedefs: > > > - update the pom.xml: royale.compiler.version to > the > > new > > > released > > > version > > > - mvn release:prepare > -DautoversionSubmodules=true > > > - mvn release:perform > > > - royale-asjs: > > > - update the pom.xml: royale.compiler.version and > > > royale.typedefs.version to the new released > version > > > - mvn release:prepare > -DautoversionSubmodules=true > > > - mvn release:perform > > > > > > > > > This combined with all the past effort done by Alex and > > Piotr, > > > should lower > > > the suffering of doing a release :) > > > > > > Carlos > > > > > > > > > > > > El vie., 15 nov. 2019 a las 15:46, Carlos Rovira (< > > > [email protected]>) > > > escribió: > > > > > > > Great you like it Harbs! :) > > > > > > > > I forgot to mention that another effort in parallel > is to > > > release v1.0.0 > > > > of "flex-sdk-converter-maven-extension" (located in > Apache > > Flex > > > utilities > > > > repo), > > > > so we can remove the need to add "-s > > settings-template.xml" to > > > each line, > > > > what will improve event more the build process by > reducing > > > verbosity :) > > > > > > > > > > > > > > > > > > > > El vie., 15 nov. 2019 a las 14:03, Harbs (< > > [email protected] > > > >) > > > > escribió: > > > > > > > >> If it all works, sounds great to me! :-) (I’m not > going > > to be > > > able to > > > >> test until sometime next week, but don’t wait for > me.) > > > >> > > > >> Thanks to Chris for working on this! > > > >> > > > >> Harbs > > > >> > > > >> > On Nov 15, 2019, at 2:45 PM, Carlos Rovira < > > > [email protected]> > > > >> wrote: > > > >> > > > > >> > Hi, > > > >> > > > > >> > this days Chris Dutz has had the deference and > detail of > > > working on > > > >> > improving Apache Royale Maven build by > simplifying the > > > scripts so we all > > > >> > have less headaches with all this stuff that he > knows > > and > > > master so > > > >> well. > > > >> > I want to give a big thanks to Chris for > investing his > > time > > > in working > > > >> on > > > >> > this huge improvement that for sure will help all > us > > when > > > building > > > >> royale > > > >> > in the daily basis and as well when having to > make a new > > > release. > > > >> > > > > >> > So Chris created 3 PRs that are for each repo to > test. > > > >> > > > > >> > I already tested it and simplify all greatly. > > > >> > > > > >> > Here the recipe for building everything including > tests > > and > > > UI tests > > > >> and so > > > >> > on: > > > >> > > > > >> > #!/bin/bash > > > >> > > > > >> > *export* > > > >> > > > > > > FLASHPLAYER_DEBUGGER="/Users/christofer.dutz/Devtools/Adobe/Flash/FlashPlayer-32.0/Flash > > > >> > Player.app/Contents/MacOS/Flash Player Debugger" > > > >> > > > > >> > *cd* royale-compiler > > > >> > > > > >> > ./mvnw install -s settings-template.xml > > > >> > > > > >> > *cd* ../royale-typedefs > > > >> > > > > >> > ./mvnw install -s settings-template.xml > > > >> > > > > >> > *cd* ../royale-asjs > > > >> > > > > >> > ./mvnw install -s settings-template.xml -P > > > >> > > > > > with-examples,with-distribution,with-ui-testsuite,option-with-swf > > > >> > > > > > -Dwebdriver.gecko.driver=/Users/christofer.dutz/Downloads/geckodriver > > > >> > > > > >> > *cd* .. > > > >> > > > > >> > > > > >> > you can use mvn or mvnw that will install Maven > if you > > don't > > > have any > > > >> > installed :) > > > >> > > > > >> > > > > >> > > > > >> > You probably need to adjust the paths to the > > > FLASHPLAYER_DEBUGGER as > > > >> well > > > >> > as for the geckodriver > > > >> > > > > >> > (If you don’t want to execute the Selenium UI > tests in > > > Firefox, just > > > >> omit > > > >> > the “with-ui-testsuite” profile) > > > >> > > > > >> > (Noting that I should add a Firefox detection to > my > > > prerequisite check) > > > >> > > > > >> > > > > >> > You should not need to have > FLASHPLAYERGLOBAL_HOME and > > > >> > FLASHPLAYERGLOBAL_VERSION > > > >> > > > > >> > > > > >> > > > > >> > The profiles: > > > >> > > > > >> > - *with-examples*: Well it builds the examples > too > > > >> > - *with-distribution*: It lets the build also > build > > the > > > distribution > > > >> > (this part is still incomplete, since like > today, it > > does > > > not > > > >> generate a > > > >> > valid SDK, but I'll work on this with Chris > this next > > week). > > > >> > - *option-with-swf*: It also makes each module > build > > the > > > swf version > > > >> > - *with-ui-testsuite*: It also builds the > testsuite > > modules > > > and runs > > > >> the > > > >> > integration-tests > > > >> > > > > >> > > > > >> > This PRs also introduces many fixes like a SASS > new > > version > > > that handles > > > >> > memory better (that was causing all process to > hang when > > > launching all > > > >> in > > > >> > one single instruction due to memory leaks). > Please > > revise > > > the PRs to > > > >> read > > > >> > about all the list of improvements in this update. > > > >> > > > > >> > So If nobody opposite, I'd like to merge this > > improvement in > > > the next > > > >> hours. > > > >> > > > > >> > Thanks! :) > > > >> > > > > >> > -- > > > >> > Carlos Rovira > > > >> > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1fffda5fc31746cda1ae08d76a09751d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094461160068663&sdata=elGX%2F3esJ4w2l1Z7HhNwhVa7pLsxUxFvCvUZgkhDikk%3D&reserved=0 > > > >> > > > >> > > > > > > > > -- > > > > Carlos Rovira > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1fffda5fc31746cda1ae08d76a09751d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094461160068663&sdata=elGX%2F3esJ4w2l1Z7HhNwhVa7pLsxUxFvCvUZgkhDikk%3D&reserved=0 > > > > > > > > > > > > > > -- > > > Carlos Rovira > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1fffda5fc31746cda1ae08d76a09751d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094461160068663&sdata=elGX%2F3esJ4w2l1Z7HhNwhVa7pLsxUxFvCvUZgkhDikk%3D&reserved=0 > > > > > > > > > > > > > > > > > > > -- > > Carlos Rovira > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1fffda5fc31746cda1ae08d76a09751d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094461160078661&sdata=I7F8lDNwEwxGriYNa6%2F447Q1YuOra0nihw1GL%2FBMbT8%3D&reserved=0 > > > > > > > > -- > Carlos Rovira > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1fffda5fc31746cda1ae08d76a09751d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637094461160078661&sdata=I7F8lDNwEwxGriYNa6%2F447Q1YuOra0nihw1GL%2FBMbT8%3D&reserved=0 > > > -- Carlos Rovira http://about.me/carlosrovira
