Thanks Andrew and Harbs, @Harbs, I'll check it and get back to you. El dom., 2 feb. 2020 a las 15:49, Andrew Wetmore (<cottag...@gmail.com>) escribió:
> Tiny quibble: > > I have seven items on my to-do list. The indicator at the bottom left says > "7 item left". That should be "items" in the plural when the count is > anything but 1. > > a > > On Sat, Feb 1, 2020 at 6:34 PM Harbs <harbs.li...@gmail.com> wrote: > > > Carlos, > > > > I made some improvements to Router and I changed the todo app to use the > > new router features which automatically sync state with the router. > > > > Something is odd with Jewel ToggleButtons and state. I’m not sure what it > > is, but once the buttons are clicked once, they never revert to an > > unselected state. > > > > Can you look at the feature/router branch and see if you can figure out > > what’s wrong? > > > > > On Feb 1, 2020, at 3:34 AM, Carlos Rovira <carlosrov...@apache.org> > > wrote: > > > > > > Thanks for the feedback Andrew, much appreciated! :) > > > > > > just uploaded a new version now, I finish all, even the check box style > > to match todomvc. This is the new URL: > > > > > > https://royale.apache.org/todomvc-jewel/ < > > https://royale.apache.org/todomvc-jewel/> > > > > > > And the changes: > > > > > > - Jewel CheckBox look change to mimic todomvc style > > > - toggleAll change style if all items is marked/unmaked > > > - Item edit mode now exits with "click outside" > > > - Item edit mode now removes the item if user removes all text > > > - Finish little style things through all example to match todomvc as > > much as possible > > > > > > About the max number of chars, it seems that is not on the original > > TodoMVC, so I didn't implement it, since I think we need to just mimic > what > > they have. > > > > > > If you (or others) find other issues please let me know, so we can make > > it as accurate as possible to todomvc. > > > > > > I consider it complete now, unless new bugs arise :) > > > > > > Thanks! > > > > > > Carlos > > > > > > > > > > > > > > > > > > El vie., 31 ene. 2020 a las 16:00, Andrew Wetmore (< > cottag...@gmail.com > > <mailto:cottag...@gmail.com>>) escribió: > > > This is very good! > > > > > > There seems to be no maximum limit to the number of characters in a > > note; certainly there is no character count or anything to let me know > if I > > am coming close to a limit. > > > > > > A more serious problem occurs when you create an entry, then double > > click to edit it, and remove all the contents from the entry. The app > seems > > to get into a funny state. I think the best behavior would be to delete > the > > entry if it is saved with no contents. > > > > > > a > > > > > > On Fri, Jan 31, 2020 at 7:13 AM Carlos Rovira <carlosrov...@apache.org > > <mailto:carlosrov...@apache.org>> wrote: > > > Thanks Om and Ramazan! :) > > > > > > The source code was posted in the initial comment on this thread ;) > > > > > > Best > > > > > > Carlos > > > > > > > > > > > > El vie., 31 ene. 2020 a las 1:34, Ramazan Ergüder Bekrek (< > > e.bek...@yandex.com <mailto:e.bek...@yandex.com>>) escribió: > > > Carlos can you point out where is the source code for this? > > > > > > I remember trying to learn React the first time just to do this > > application and > > > it was such a pain to learn the framework. Now that I can code it with > > Actionscript > > > I'm getting excited. > > > > > > Thank you for your contribution > > > > > > > > > > > > 31.01.2020, 00:58, "OmPrakash Muppirala" <omup...@gmail.com <mailto: > > omup...@gmail.com>>: > > > Carlos, > > > > > > This is simply amazing. Great job on porting the standard TodoMVC app > > to Royale! > > > > > > Om > > > > > > On Thu, Jan 30, 2020 at 2:27 PM Carlos Rovira <carlosrov...@apache.org > > <mailto:carlosrov...@apache.org>> wrote: > > > Hi All, > > > > > > just upload a first version of TodoMVC to the website. It implements > all > > functionality, with Routing and Local Storage included. > > > Is done with Jewel UI Set showing how you can customize look and feel > of > > included components (Button, Toggles, List, TextInput, BarRow...). > > > Still I need to customize the main checkboxes to match the real example > > to finish it completely ( I still didn't have time). Hope to do soon. > > > > > > I'll plan to do another version with Crux, so people could see the > > diferences between both, but I worked hard to make this very MVC, > ensuring > > separation is done correctly, using, events, models, views and > controllers. > > Let me know what you think or if you find any bug or some issue: > > > > > > https://royale.apache.org/todomvc <https://royale.apache.org/todomvc> > > > > > > I expect to send to the original website (http://todomvc.com < > > http://todomvc.com/>) when is finished completely and see if they can > > aggregate. > > > > > > Source code is here for you to browse: > > > > > > > > > https://github.com/apache/royale-asjs/tree/develop/examples/jewel/todomvc > > < > https://github.com/apache/royale-asjs/tree/develop/examples/jewel/todomvc > > > > > > > > > I'll write about some issues I found tomorrow while writing this, in > the > > other hand I felt this experiment was a pleasure to do since Royale seems > > very robust today as a technology, and we can call it 1.0. Things like > > Routing, LocalStorage, Components are mostly all there to use. > > > > > > This was my first experiment customizing visuals in Jewel and I think > it > > was very quick to do it. > > > > > > I tried to make all the example well organized and commented, and > expect > > to write some docs about it. As always problem is time. > > > > > > HTH. > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira <http://about.me/carlosrovira> > > > > > > > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira <http://about.me/carlosrovira> > > > > > > > > > > > > -- > > > Andrew Wetmore > > > > > > http://cottage14.blogspot.com/ <http://cottage14.blogspot.com/> > > > > > > > > > > > > > > > > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira <http://about.me/carlosrovira> > > > > > > > > > -- > Andrew Wetmore > > http://cottage14.blogspot.com/ > -- Carlos Rovira http://about.me/carlosrovira
