Hi all,
I confirm Alex' findings.
The reason is that in the release-branch the version of the asjs artifacts
differs from that of the compiler.
The compiler version is 0.9.7 but the asjs version is 0.9.8-SNAPSHOT.
In general we should probably update the "rars" sub-modules of the distribution
to use ${royale.compiler.version} as version.
But the current state in "release/0.9.7" isn't a real valid state anyway ...
usually you would probably bump the compiler and typedefs versions to the new
SNAPSHOT versions after releasing the module. In that case the versions would
be back in sync.
Regarding the release ... I think this doesn't have any impact on the release
itself. Cause in this the compiler, typedefs and asjs all have the version
0.9.7 and therefore this shouldn't be an issue.
I'll checkout the release-tag and try again and report back.
Chris
Am 06.05.20, 09:51 schrieb "Christofer Dutz" <[email protected]>:
Hi all,
Just some background to get rid of the confusion:
The "with-distribution" enables the distributions you make Maven build the
archives ... if you provide the distributionTargetFolder property it also
builds an "exploded" version, which you can directly use in an IDE. If you
execute the build in the distribution folder, you don't even need to activate
the "with-distribution" profile.
The artifact it's looking for is one of the jars built as child modules of
the distribution, which just take a compiler artifact and changes the
executable class. So if you build the distribution module, so should the
sub-module.
One thing ... @Alex did you just execute the distribution and prevent maven
from building anything else? Then this will be the cause ... as you haven't
enabled the "with-distribution" profile, maven won't build it but also not the
9 sub-modules of that module ... so if you now just build only the distribution
module, it will not find the other stuff it's looking for.
So I just built the distribution in develop and all worked ... now I'm
switching to the release-branch (is there a reason they are called "rel/0.9.7"
for compiler and typedefs and "release/0.9.7" for asjs?
Will report anything I find.
Chris
Am 06.05.20, 07:32 schrieb "Alex Harui" <[email protected]>:
FWIW, I added -DdistributionTargetFolder= and still the same failure.
On 5/5/20, 4:29 PM, "Alex Harui" <[email protected]> wrote:
Maybe. I can't find how to do that in the instructions. I assumed
it would end up in a "target" folder.
On 5/5/20, 3:09 PM, "Piotr Zarzycki" <[email protected]>
wrote:
Shouldn't you add path where distribution will be saved?
On Tue, May 5, 2020, 7:25 PM Alex Harui
<[email protected]> wrote:
> It may be too early in the morning for me, but I switched to
the
> release/0.9.7 branch in all 3 repos, did a "mvn clean
install" all of them,
> then back in royale-asjs I ran
> "mvn -Pwith-distribution clean install" and got an error:
>
> Failed to create assembly: Error adding file to archive:
>
/Users/aharui/git/royale/maven/royale-asjs/distribution/jars/compiler-mxmljsc/target/compiler-mxmljsc-0.9.7.jar
>
> Interestingly, maybe related, the output on the CI server
says things like
> " Skipping the assembly in this project because it's not the
Execution
> Root" which may be why it gets past this point. So I think
we're missing
> something somewhere. I thought it would be as simple as
selecting that
> profile.
>
> Thoughts?
> -Alex
>
>
