Hi Piotr, I was asking myself the same the some days ago while doing the Item Renderer layout refactor. Hope Greg can tell us. Maybe he needed for some client integration.
El mar., 26 may. 2020 a las 16:00, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > Hi Carlos, > > Do you know why method "getSelectedSubmenuItem" has condition checking > whether sub menu is open ? I think it not correct, but I may not see some > scenario - do you have inside for that ? > > [1] > > https://github.com/apache/royale-asjs/blob/33705c18b0ea56ebd38ae068c24deaf2f166e727/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as#L98 > > Thanks, > Piotr > > niedz., 17 maj 2020 o 12:21 Carlos Rovira <carlosrov...@apache.org> > napisał(a): > > > Hi Piotr, > > I think fixed it, also a double "change" issue in sub menu items. > > > > El dom., 17 may. 2020 a las 10:30, Piotr Zarzycki (< > > piotrzarzyck...@gmail.com>) escribió: > > > > > Hi Carlos, > > > > > > Ok list seems to work better, but items "no-submenu" are not clickable > - > > > they do not produce "change" event at all. > > > > > > Thanks, > > > Piotr > > > > > > sob., 16 maj 2020 o 12:16 Carlos Rovira <carlosrov...@apache.org> > > > napisał(a): > > > > > > > Hi Piotr, > > > > > > > > ok, I think I solved it in my latest commit. check it and let me know > > it > > > > that solve your problem. > > > > > > > > Basically, I think options with no submenu needs to be consistent > with > > > the > > > > rest of renders that are not collapsible. > > > > So I'm adding CSS style "no-submenu" when collapsible render knows > > > there's > > > > no childs in the list, otherwise it behaves as before. > > > > > > > > El sáb., 16 may. 2020 a las 10:35, Piotr Zarzycki (< > > > > piotrzarzyck...@gmail.com>) escribió: > > > > > > > > > Hi Carlos, > > > > > > > > > > Ok here is the simple question - How would you style in TourDeJewel > > > item > > > > in > > > > > menu called "No SubMenu" ? > > > > > > > > > > I would like to have that item behave as any other item - I need > roll > > > > over > > > > > color on it, it needs to be clickable etc. > > > > > > > > > > Thanks, > > > > > Piotr > > > > > > > > > > sob., 16 maj 2020 o 09:51 Carlos Rovira <carlosrov...@apache.org> > > > > > napisał(a): > > > > > > > > > > > Hi Piotr, > > > > > > > > > > > > sorry, but I read the email and analized code (that I have fresh > > > since > > > > I > > > > > > had to update it recently), but still don't know what the problem > > is. > > > > > > Can you reformulate so I can understand it? > > > > > > Sorry > > > > > > thanks > > > > > > > > > > > > El vie., 15 may. 2020 a las 18:33, Piotr Zarzycki (< > > > > > > piotrzarzyck...@gmail.com>) escribió: > > > > > > > > > > > > > Hi Guys, > > > > > > > > > > > > > > We would like to use CollapsibleNavigationSectionRenderer in > our > > > > > > > application - however I have found case where there is problem > > with > > > > > > styling > > > > > > > some items in current implementation. > > > > > > > > > > > > > > In TourDeJewel we have item called "No SubMenu" - This > particular > > > > item > > > > > I > > > > > > > would like to behave the same as any other item if it would be > > non > > > > > > > collapsible type of renderer. > > > > > > > > > > > > > > If item has some children we can add class to "Navigation" > > > component > > > > by > > > > > > > overriding childNavClassName [1] , but how to styling "No > > SubMenu" > > > ? > > > > > > > > > > > > > > If there is not children in HTML we have following structure > [2] > > > and > > > > > > custom > > > > > > > class which make my items looks as I wanted to called > > > > > > > navIconLinkItemRenderer > > > > > > > . > > > > > > > > > > > > > > Analysis: > > > > > > > First "nav" has my class navIconLinkItemRenderer > > > > > > > Third "nav" has my class cause I have added it to > > > childNavClassName > > > > > > > > > > > > > > Second "nav" doesn't have my class, cause there is not option > to > > > add > > > > it > > > > > > or > > > > > > > actually this is not fully "Navigation" type of component. You > > are > > > > not > > > > > > able > > > > > > > to actually select it, truly click it and so on. > > > > > > > > > > > > > > Thoughts on that ? > > > > > > > > > > > > > > I hope you will understand my description. > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/royale-asjs/blob/3ee6f24eb7977c054b480ecea2c471dab017fadf/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/CollapsibleNavigationSectionRenderer.as#L174 > > > > > > > [2] https://ibb.co/HGn0s3X > > > > > > > > > > > > > > Thanks, > > > > > > > -- > > > > > > > > > > > > > > Piotr Zarzycki > > > > > > > > > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > > > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Piotr Zarzycki > > > > > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
