Hi Harbs I removed it since I created in the past with the objective to deal with the hoverable/selectable states, since Jewel needed.
As soon as Alex did the item renderer improvement, that interface was not required anymore. The proof is no code in Royale was using it since Alex cleaned code from using it and the actual initializer architecture made us use "has" instead of turn on/off behaviors. Sorry for the problems of removing it. I was in the belief that if the code is not used in Royale we should remove it to avoid dead code. My opinion is that if you still need to use that interface in Spectrum should go to that library, since Royale doesn't use it, and in that way we avoid confusion for us and for new users Thoughts? Thanks El lun., 29 jun. 2020 a las 12:29, Harbs (<harbs.li...@gmail.com>) escribió: > ISelectableItemRenderer does not have the selectable property which is > used by Spectrum. > > > On Jun 29, 2020, at 1:21 PM, Harbs <harbs.li...@gmail.com> wrote: > > > > Why did you remove this interface? > > > > It’s used by Spectrum and should really be adopted by other components > as well. > > > > Please ask before removing things in the future. > > > >> On Jun 11, 2020, at 6:01 PM, carlosrov...@apache.org wrote: > >> > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> carlosrovira pushed a commit to branch develop > >> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > >> > >> > >> The following commit(s) were added to refs/heads/develop by this push: > >> new d997c70 core-IRuntimeSelectableItemRenderer: remove unused > interface > >> d997c70 is described below > >> > >> commit d997c703461167b2072ba75d6ff9215124814d0f > >> Author: Carlos Rovira <carlos.rov...@apache.org> > >> AuthorDate: Thu Jun 11 17:01:15 2020 +0200 > >> > >> core-IRuntimeSelectableItemRenderer: remove unused interface > >> --- > >> .../projects/Core/src/main/royale/CoreClasses.as | 1 - > >> .../royale/core/IRuntimeSelectableItemRenderer.as | 64 > ---------------------- > >> 2 files changed, 65 deletions(-) > >> > >> diff --git a/frameworks/projects/Core/src/main/royale/CoreClasses.as > b/frameworks/projects/Core/src/main/royale/CoreClasses.as > >> index ff662a0..cba38dc 100644 > >> --- a/frameworks/projects/Core/src/main/royale/CoreClasses.as > >> +++ b/frameworks/projects/Core/src/main/royale/CoreClasses.as > >> @@ -146,7 +146,6 @@ internal class CoreClasses > >> import org.apache.royale.core.IScrollBarModel; > IScrollBarModel; > >> } > >> import org.apache.royale.core.IListDataItemRenderer; > IListDataItemRenderer; > >> - import org.apache.royale.core.IRuntimeSelectableItemRenderer; > IRuntimeSelectableItemRenderer; > >> import org.apache.royale.core.ISelectableItemRenderer; > ISelectableItemRenderer; > >> import org.apache.royale.core.ISelectable; ISelectable; > >> import org.apache.royale.core.ISelectionModel; ISelectionModel; > >> diff --git > a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as > b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as > >> deleted file mode 100644 > >> index d5df28b..0000000 > >> --- > a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as > >> +++ /dev/null > >> @@ -1,64 +0,0 @@ > >> > -//////////////////////////////////////////////////////////////////////////////// > >> -// > >> -// Licensed to the Apache Software Foundation (ASF) under one or more > >> -// contributor license agreements. See the NOTICE file distributed > with > >> -// this work for additional information regarding copyright ownership. > >> -// The ASF licenses this file to You under the Apache License, > Version 2.0 > >> -// (the "License"); you may not use this file except in compliance > with > >> -// the License. You may obtain a copy of the License at > >> -// > >> -// http://www.apache.org/licenses/LICENSE-2.0 > >> -// > >> -// Unless required by applicable law or agreed to in writing, software > >> -// distributed under the License is distributed on an "AS IS" BASIS, > >> -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > >> -// See the License for the specific language governing permissions and > >> -// limitations under the License. > >> -// > >> > -//////////////////////////////////////////////////////////////////////////////// > >> -package org.apache.royale.core > >> -{ > >> - import org.apache.royale.events.IEventDispatcher; > >> - > >> - /** > >> - * The IItemRenderer interface is the basic interface for item > renderers. > >> - * More complex item renderers may implements extensions of this > interface. > >> - * > >> - * @langversion 3.0 > >> - * @playerversion Flash 10.2 > >> - * @playerversion AIR 2.6 > >> - * @productversion Royale 0.0 > >> - */ > >> - public interface IRuntimeSelectableItemRenderer extends > ISelectableItemRenderer > >> - { > >> - /** > >> - * <code>true</code> if the item renderer is can be selected > >> - * false otherwise. Use to configure a renderer to be non > >> - * selectable. > >> - * > >> - * Defaults to true > >> - * > >> - * @langversion 3.0 > >> - * @playerversion Flash 10.2 > >> - * @playerversion AIR 2.6 > >> - * @productversion Royale 0.9.3 > >> - */ > >> - function get selectable():Boolean; > >> - function set selectable(value:Boolean):void; > >> - > >> - /** > >> - * <code>true</code> if the item renderer is can be hovered > >> - * false otherwise. Use to configure a renderer to be non > >> - * hoverable. > >> - * > >> - * Defaults to true > >> - * > >> - * @langversion 3.0 > >> - * @playerversion Flash 10.2 > >> - * @playerversion AIR 2.6 > >> - * @productversion Royale 0.9.3 > >> - */ > >> - function get hoverable():Boolean; > >> - function set hoverable(value:Boolean):void; > >> - } > >> -} > >> > > > > -- Carlos Rovira http://about.me/carlosrovira
