Great. Thanks!
> On Jun 29, 2020, at 6:45 PM, Josh Tynjala <[email protected]> wrote:
>
> ActionScript has [Deprecated] metadata that is supported by the Royale
> compiler. The compiler will output warnings when deprecated APIs are used.
> Editors/IDEs can also use this information to render things differently.
>
> Example:
> https://twitter.com/as3mxml/status/1192101486563483649
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Mon, Jun 29, 2020 at 4:40 AM Christofer Dutz <[email protected]>
> wrote:
>
>> Does Royale have something like a "@Deprecated" mechanism, where things
>> could be scheduled for removal and the compiler could output usage of
>> deprecated stuff?
>> Perhaps something like that could avoid problems like that in the future?
>>
>> Chris
>>
>> Am 29.06.20, 13:27 schrieb "Harbs" <[email protected]>:
>>
>> I can add the interface to Spectrum if there’s consensus it does not
>> belong in Royale. I’m not convinced that’s the case. I’d like to hear what
>> others think.
>>
>> Spectrum has been modified to use selection beads, but I encapsulated
>> that all within the components. One of my goals with Spectrum was to make
>> it as easy to use as possible without messing with beads more than
>> necessary. One of those was having selectable and hoverable getter/setter.
>>
>> Either way, you should always assume that there’s the possibility that
>> someone is using a piece of Royale and if you want to change or remove
>> something, please bring it up so we can discuss it.
>>
>> In the meantime I reverted your commit. If there’s consensus that we
>> should remove it, we can do that once I (and anyone else who is using it)
>> has an opportunity to modify their code.
>>
>> Thanks,
>> Harbs
>>
>>> On Jun 29, 2020, at 2:00 PM, Carlos Rovira <[email protected]>
>> wrote:
>>>
>>> Hi Harbs,
>>>
>>> ok, I think it would be better to do something of the following:
>>>
>>> 1.- add the interface to Spectrum lib as I said before
>>> 2.- change Spectrum to use initializers if you want to turn it to the
>>> modern implementation (of course if you have time)
>>>
>>> for now you can solve directly with 1
>>>
>>>
>>> El lun., 29 jun. 2020 a las 12:29, Harbs (<[email protected]>)
>> escribió:
>>>
>>>> ISelectableItemRenderer does not have the selectable property which
>> is
>>>> used by Spectrum.
>>>>
>>>>> On Jun 29, 2020, at 1:21 PM, Harbs <[email protected]> wrote:
>>>>>
>>>>> Why did you remove this interface?
>>>>>
>>>>> It’s used by Spectrum and should really be adopted by other
>> components
>>>> as well.
>>>>>
>>>>> Please ask before removing things in the future.
>>>>>
>>>>>> On Jun 11, 2020, at 6:01 PM, [email protected] wrote:
>>>>>>
>>>>>> This is an automated email from the ASF dual-hosted git
>> repository.
>>>>>>
>>>>>> carlosrovira pushed a commit to branch develop
>>>>>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>>>>>
>>>>>>
>>>>>> The following commit(s) were added to refs/heads/develop by this
>> push:
>>>>>> new d997c70 core-IRuntimeSelectableItemRenderer: remove unused
>>>> interface
>>>>>> d997c70 is described below
>>>>>>
>>>>>> commit d997c703461167b2072ba75d6ff9215124814d0f
>>>>>> Author: Carlos Rovira <[email protected]>
>>>>>> AuthorDate: Thu Jun 11 17:01:15 2020 +0200
>>>>>>
>>>>>> core-IRuntimeSelectableItemRenderer: remove unused interface
>>>>>> ---
>>>>>> .../projects/Core/src/main/royale/CoreClasses.as | 1 -
>>>>>> .../royale/core/IRuntimeSelectableItemRenderer.as | 64
>>>> ----------------------
>>>>>> 2 files changed, 65 deletions(-)
>>>>>>
>>>>>> diff --git
>> a/frameworks/projects/Core/src/main/royale/CoreClasses.as
>>>> b/frameworks/projects/Core/src/main/royale/CoreClasses.as
>>>>>> index ff662a0..cba38dc 100644
>>>>>> --- a/frameworks/projects/Core/src/main/royale/CoreClasses.as
>>>>>> +++ b/frameworks/projects/Core/src/main/royale/CoreClasses.as
>>>>>> @@ -146,7 +146,6 @@ internal class CoreClasses
>>>>>> import org.apache.royale.core.IScrollBarModel;
>>>> IScrollBarModel;
>>>>>> }
>>>>>> import org.apache.royale.core.IListDataItemRenderer;
>>>> IListDataItemRenderer;
>>>>>> - import org.apache.royale.core.IRuntimeSelectableItemRenderer;
>>>> IRuntimeSelectableItemRenderer;
>>>>>> import org.apache.royale.core.ISelectableItemRenderer;
>>>> ISelectableItemRenderer;
>>>>>> import org.apache.royale.core.ISelectable; ISelectable;
>>>>>> import org.apache.royale.core.ISelectionModel;
>> ISelectionModel;
>>>>>> diff --git
>>>>
>> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
>>>>
>> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
>>>>>> deleted file mode 100644
>>>>>> index d5df28b..0000000
>>>>>> ---
>>>>
>> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
>>>>>> +++ /dev/null
>>>>>> @@ -1,64 +0,0 @@
>>>>>>
>>>>
>> -////////////////////////////////////////////////////////////////////////////////
>>>>>> -//
>>>>>> -// Licensed to the Apache Software Foundation (ASF) under one
>> or more
>>>>>> -// contributor license agreements. See the NOTICE file
>> distributed
>>>> with
>>>>>> -// this work for additional information regarding copyright
>> ownership.
>>>>>> -// The ASF licenses this file to You under the Apache License,
>>>> Version 2.0
>>>>>> -// (the "License"); you may not use this file except in
>> compliance
>>>> with
>>>>>> -// the License. You may obtain a copy of the License at
>>>>>> -//
>>>>>> -// http://www.apache.org/licenses/LICENSE-2.0
>>>>>> -//
>>>>>> -// Unless required by applicable law or agreed to in writing,
>> software
>>>>>> -// distributed under the License is distributed on an "AS IS"
>> BASIS,
>>>>>> -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
>> or
>>>> implied.
>>>>>> -// See the License for the specific language governing
>> permissions and
>>>>>> -// limitations under the License.
>>>>>> -//
>>>>>>
>>>>
>> -////////////////////////////////////////////////////////////////////////////////
>>>>>> -package org.apache.royale.core
>>>>>> -{
>>>>>> - import org.apache.royale.events.IEventDispatcher;
>>>>>> -
>>>>>> - /**
>>>>>> - * The IItemRenderer interface is the basic interface for
>> item
>>>> renderers.
>>>>>> - * More complex item renderers may implements extensions of
>> this
>>>> interface.
>>>>>> - *
>>>>>> - * @langversion 3.0
>>>>>> - * @playerversion Flash 10.2
>>>>>> - * @playerversion AIR 2.6
>>>>>> - * @productversion Royale 0.0
>>>>>> - */
>>>>>> - public interface IRuntimeSelectableItemRenderer extends
>>>> ISelectableItemRenderer
>>>>>> - {
>>>>>> - /**
>>>>>> - * <code>true</code> if the item renderer is can be
>> selected
>>>>>> - * false otherwise. Use to configure a renderer to be
>> non
>>>>>> - * selectable.
>>>>>> - *
>>>>>> - * Defaults to true
>>>>>> - *
>>>>>> - * @langversion 3.0
>>>>>> - * @playerversion Flash 10.2
>>>>>> - * @playerversion AIR 2.6
>>>>>> - * @productversion Royale 0.9.3
>>>>>> - */
>>>>>> - function get selectable():Boolean;
>>>>>> - function set selectable(value:Boolean):void;
>>>>>> -
>>>>>> - /**
>>>>>> - * <code>true</code> if the item renderer is can be
>> hovered
>>>>>> - * false otherwise. Use to configure a renderer to be
>> non
>>>>>> - * hoverable.
>>>>>> - *
>>>>>> - * Defaults to true
>>>>>> - *
>>>>>> - * @langversion 3.0
>>>>>> - * @playerversion Flash 10.2
>>>>>> - * @playerversion AIR 2.6
>>>>>> - * @productversion Royale 0.9.3
>>>>>> - */
>>>>>> - function get hoverable():Boolean;
>>>>>> - function set hoverable(value:Boolean):void;
>>>>>> - }
>>>>>> -}
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>> --
>>> Carlos Rovira
>>> http://about.me/carlosrovira
>>
>>
>>