Hi Harbs

El lun., 29 jun. 2020 a las 13:27, Harbs (<harbs.li...@gmail.com>) escribió:

> I can add the interface to Spectrum if there’s consensus it does not
> belong in Royale. I’m not convinced that’s the case. I’d like to hear what
> others think.
>

Well, my point was since when I did this change Alex pointed to the problem
of adding functionality that was not PAYG. I think Initializers are really
a better option than that, so for that reason my opinion is once we got new
initializers, better to remove it from royale core. Of course, others can
use it, but maybe better outside the project enhancing the PAYG nature of
Royale.


>
> Spectrum has been modified to use selection beads, but I encapsulated that
> all within the components. One of my goals with Spectrum was to make it as
> easy to use as possible without messing with beads more than necessary. One
> of those was having selectable and hoverable getter/setter.
>

In jewel the target was the same. But I was ok with Alex removing it and
making it configurable through CSS. I don't think I loose easeness. and I
had the opportunity to play lot with it in TDJ, todomvc and other side
projects I'm doing.


> Either way, you should always assume that there’s the possibility that
> someone is using a piece of Royale and if you want to change or remove
> something, please bring it up so we can discuss it.
>

Yeah, I think this is new casuistic now, since until now I only need to
check Royale code and see that I was not breaking anything. This is
changing with this issue.


>
> In the meantime I reverted your commit. If there’s consensus that we
> should remove it, we can do that once I (and anyone else who is using it)
> has an opportunity to modify their code.
>

That's ok.

Thanks

Carlos


>
> Thanks,
> Harbs
>
> > On Jun 29, 2020, at 2:00 PM, Carlos Rovira <carlosrov...@apache.org>
> wrote:
> >
> > Hi Harbs,
> >
> > ok, I think it would be better to do something of the following:
> >
> > 1.- add the interface to Spectrum lib as I said before
> > 2.- change Spectrum to use initializers if you want to turn it to the
> > modern implementation (of course if you have time)
> >
> > for now you can solve directly with 1
> >
> >
> > El lun., 29 jun. 2020 a las 12:29, Harbs (<harbs.li...@gmail.com>)
> escribió:
> >
> >> ISelectableItemRenderer does not have the selectable property which is
> >> used by Spectrum.
> >>
> >>> On Jun 29, 2020, at 1:21 PM, Harbs <harbs.li...@gmail.com> wrote:
> >>>
> >>> Why did you remove this interface?
> >>>
> >>> It’s used by Spectrum and should really be adopted by other components
> >> as well.
> >>>
> >>> Please ask before removing things in the future.
> >>>
> >>>> On Jun 11, 2020, at 6:01 PM, carlosrov...@apache.org wrote:
> >>>>
> >>>> This is an automated email from the ASF dual-hosted git repository.
> >>>>
> >>>> carlosrovira pushed a commit to branch develop
> >>>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >>>>
> >>>>
> >>>> The following commit(s) were added to refs/heads/develop by this push:
> >>>>   new d997c70  core-IRuntimeSelectableItemRenderer: remove unused
> >> interface
> >>>> d997c70 is described below
> >>>>
> >>>> commit d997c703461167b2072ba75d6ff9215124814d0f
> >>>> Author: Carlos Rovira <carlos.rov...@apache.org>
> >>>> AuthorDate: Thu Jun 11 17:01:15 2020 +0200
> >>>>
> >>>>  core-IRuntimeSelectableItemRenderer: remove unused interface
> >>>> ---
> >>>> .../projects/Core/src/main/royale/CoreClasses.as   |  1 -
> >>>> .../royale/core/IRuntimeSelectableItemRenderer.as  | 64
> >> ----------------------
> >>>> 2 files changed, 65 deletions(-)
> >>>>
> >>>> diff --git a/frameworks/projects/Core/src/main/royale/CoreClasses.as
> >> b/frameworks/projects/Core/src/main/royale/CoreClasses.as
> >>>> index ff662a0..cba38dc 100644
> >>>> --- a/frameworks/projects/Core/src/main/royale/CoreClasses.as
> >>>> +++ b/frameworks/projects/Core/src/main/royale/CoreClasses.as
> >>>> @@ -146,7 +146,6 @@ internal class CoreClasses
> >>>>             import org.apache.royale.core.IScrollBarModel;
> >> IScrollBarModel;
> >>>>     }
> >>>>     import org.apache.royale.core.IListDataItemRenderer;
> >> IListDataItemRenderer;
> >>>> -    import org.apache.royale.core.IRuntimeSelectableItemRenderer;
> >> IRuntimeSelectableItemRenderer;
> >>>>     import org.apache.royale.core.ISelectableItemRenderer;
> >> ISelectableItemRenderer;
> >>>>     import org.apache.royale.core.ISelectable; ISelectable;
> >>>>     import org.apache.royale.core.ISelectionModel; ISelectionModel;
> >>>> diff --git
> >>
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
> >>
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
> >>>> deleted file mode 100644
> >>>> index d5df28b..0000000
> >>>> ---
> >>
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/IRuntimeSelectableItemRenderer.as
> >>>> +++ /dev/null
> >>>> @@ -1,64 +0,0 @@
> >>>>
> >>
> -////////////////////////////////////////////////////////////////////////////////
> >>>> -//
> >>>> -//  Licensed to the Apache Software Foundation (ASF) under one or
> more
> >>>> -//  contributor license agreements.  See the NOTICE file distributed
> >> with
> >>>> -//  this work for additional information regarding copyright
> ownership.
> >>>> -//  The ASF licenses this file to You under the Apache License,
> >> Version 2.0
> >>>> -//  (the "License"); you may not use this file except in compliance
> >> with
> >>>> -//  the License.  You may obtain a copy of the License at
> >>>> -//
> >>>> -//      http://www.apache.org/licenses/LICENSE-2.0
> >>>> -//
> >>>> -//  Unless required by applicable law or agreed to in writing,
> software
> >>>> -//  distributed under the License is distributed on an "AS IS" BASIS,
> >>>> -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >> implied.
> >>>> -//  See the License for the specific language governing permissions
> and
> >>>> -//  limitations under the License.
> >>>> -//
> >>>>
> >>
> -////////////////////////////////////////////////////////////////////////////////
> >>>> -package org.apache.royale.core
> >>>> -{
> >>>> -    import org.apache.royale.events.IEventDispatcher;
> >>>> -
> >>>> -    /**
> >>>> -     *  The IItemRenderer interface is the basic interface for item
> >> renderers.
> >>>> -     *  More complex item renderers may implements extensions of this
> >> interface.
> >>>> -     *
> >>>> -     *  @langversion 3.0
> >>>> -     *  @playerversion Flash 10.2
> >>>> -     *  @playerversion AIR 2.6
> >>>> -     *  @productversion Royale 0.0
> >>>> -     */
> >>>> -    public interface IRuntimeSelectableItemRenderer extends
> >> ISelectableItemRenderer
> >>>> -    {
> >>>> -            /**
> >>>> -         *  <code>true</code> if the item renderer is can be selected
> >>>> -         *  false otherwise. Use to configure a renderer to be non
> >>>> -         *  selectable.
> >>>> -         *
> >>>> -         *  Defaults to true
> >>>> -         *
> >>>> -         *  @langversion 3.0
> >>>> -         *  @playerversion Flash 10.2
> >>>> -         *  @playerversion AIR 2.6
> >>>> -         *  @productversion Royale 0.9.3
> >>>> -         */
> >>>> -            function get selectable():Boolean;
> >>>> -            function set selectable(value:Boolean):void;
> >>>> -
> >>>> -        /**
> >>>> -         *  <code>true</code> if the item renderer is can be hovered
> >>>> -         *  false otherwise. Use to configure a renderer to be non
> >>>> -         *  hoverable.
> >>>> -         *
> >>>> -         *  Defaults to true
> >>>> -         *
> >>>> -         *  @langversion 3.0
> >>>> -         *  @playerversion Flash 10.2
> >>>> -         *  @playerversion AIR 2.6
> >>>> -         *  @productversion Royale 0.9.3
> >>>> -         */
> >>>> -            function get hoverable():Boolean;
> >>>> -            function set hoverable(value:Boolean):void;
> >>>> -    }
> >>>> -}
> >>>>
> >>>
> >>
> >>
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Reply via email to