Yes I have more extension of current Form - I didn't commit this to Royale in the results of our discussion a while ago. I have made significant changes to FormView to improve it and created stacked form layout.
Anyway go ahead and do whatever you think - let me know and I will apply your changes to our app using your branch. śr., 9 wrz 2020 o 09:40 Carlos Rovira <[email protected]> napisał(a): > Hi Piotr, > > don't understand all you said. You mean you have a stacked form layout > now? that maybe is because you created your own extensions? > > I think the objective here should be to work on a final implementation > that makes the Form/FormItem components behave in the most general way > while it's easy to do other kinds of layouts. I'm afraid of people having > problems as they start using it because the actual Form set is very > "particular". So it's not a problem for me to work on that to make it as > more "general" as possible. As I end changes you can I'll try to give a way > to make it work as before too, I hopefully think it could be possible. > Other things could be if people have some personal extensions or changes, > since that could make it more difficult for them to change to the new one, > but I expect the new Form will have a better look and feel. > > > El mié., 9 sept. 2020 a las 9:30, Piotr Zarzycki (< > [email protected]>) escribió: > >> Carlos, >> >> If you won't do stacked in the first shot - I won't use it - We have a >> lot of stacked stuff in our app. Without it it will just fail and apart of >> changing code I will have to change more.. Sure if I have time I will help, >> but I cannot promise I will get time for this from company. >> >> Having stuff in branch prevents me from changing my app till >> everything work fully. - I can test stuf separately - instead deal with >> some changes earlier in app and hold myself from using newest nightly. >> Branch is the way to go in my opinion. >> >> Thanks, >> Piotr >> >> śr., 9 wrz 2020 o 09:25 Carlos Rovira <[email protected]> >> napisał(a): >> >>> Hi Piotr, >>> >>> (sending this to both user and dev since it affects to current users and >>> we're discussing how to work on it) >>> >>> I prefer your approach to work in a branch over the current Form code, >>> when finished it will require as well do some changes in final user code so >>> in the end changes should be done one way or the other. it's ok for me. >>> I'll be waiting a bit for any other input about this, and if nobody >>> opposite will go that route. >>> >>> I think the default will become "stacked" since I think is the most >>> typical/used, then we can have other flavours like the current layout >>> (horizontal) and even the one show in vuetify or material where labels >>> start as prompt and then shrink to the top of the control (for textinput), >>> but I guess this could be a bead at form level that. Probably for people >>> happy with the current layout they could continue using it overriding the >>> set of default beads in his app's css (hopefully). >>> >>> >>> >>> El mié., 9 sept. 2020 a las 8:34, Piotr Zarzycki (< >>> [email protected]>) escribió: >>> >>>> Hi Carlos, >>>> >>>> If you think about changing name of the current component to FormDPCT >>>> and write new one with old name - I prefer if you do just the opposite. >>>> Name your new component in some way - once you will be ready - we will test >>>> it and decide how it's working. >>>> >>>> IMO it should be done on the branch - if that's the case you can even >>>> do not have name/rename, but just go ahead and change current Form. >>>> >>>> I do definitely wanted to see FormItem working as it is now + have >>>> stacked Form item where label is on top - you can search - there were such >>>> component in flex. >>>> >>>> I think also that our Form shouldn't contains to many pieces - Right >>>> now I have label on the left, container on the right - it's taking too much >>>> space - even if it will be super responsive. >>>> I do work daily with Vuetify and this is good and non heavy example how >>>> Forms should work and eventually look like [1] >>>> >>>> [1] https://vuetifyjs.com/en/components/forms/#forms >>>> >>>> Thanks, >>>> Piotr >>>> >>>> wt., 8 wrz 2020 o 22:47 Carlos Rovira <[email protected]> >>>> napisał(a): >>>> >>>>> Hi all, >>>>> >>>>> Jewel Form and FormItem specially, was implemented in a way that I >>>>> never was happy. Also others like Piotr had problems doing certain things. >>>>> So I was thinking of doing a big refactor, I think it will be >>>>> important before we reach 1.0. But before doing this I was thinking first >>>>> of leaving the actual Form and FormItem code available for some time as >>>>> "deprecated" to be able to take the name for the new components. Another >>>>> option could be to make the refactor over the actual control, but that >>>>> will >>>>> mean breaking actual code, so I think that will be a bad idea. Doing this >>>>> way, you just need to rename both components in all your apps to the new >>>>> name so that seems pretty easy so far. >>>>> >>>>> So the name could be "FormDPCT" and "FormItemDPCT" (DPCT for >>>>> "Deprecated"). That means that initially, Form and FormDPCT will have the >>>>> same code, and FormItem and FormItemDPCT will have the same code too. If >>>>> you have other proposals for the new name let me know. >>>>> >>>>> The refactor will do a better Form and FormItem responsive, so I think >>>>> it is better to layout vertically (label then content controls) by default >>>>> and take all available width in mobile screens. I think we'll need two >>>>> layouts for the FormItem, one for layout label and content controls, and >>>>> other for the content controls itself. Default will be all vertical. >>>>> >>>>> Then we'll be able to add other jewel layout beads to make all >>>>> horizontal or just some parts. >>>>> I think that way we'll have all flexibility. >>>>> >>>>> @Piotr (and others). I think it is the time to put in this thread >>>>> anything you think I should consider in this refactor, so if you remember >>>>> the main issues please take the time to log in this thread so I can have >>>>> in >>>>> mind. >>>>> >>>>> -- >>>>> Carlos Rovira >>>>> http://about.me/carlosrovira >>>>> >>>>> >>>> >>>> -- >>>> >>>> Piotr Zarzycki >>>> >>> >>> >>> -- >>> Carlos Rovira >>> http://about.me/carlosrovira >>> >>> >> >> -- >> >> Piotr Zarzycki >> > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Piotr Zarzycki
