Hi Maria,

I have reviewed your ECharts implementation and I see one things which may
or may not be an improvement. In example application there is
interface IEchartDefinition. I feel like it should be part of EChart lib
itself.

I will try to use your implementation and see if I'm enough comfortable
with it to replace mine.

Thanks,
Piotr

sob., 15 sie 2020 o 11:23 Carlos Rovira <carlosrov...@apache.org>
napisał(a):

> Hi,
>
> As Brian said
>
> "org.apache.royale.utilities.converter:flex-sdk-converter-maven-extension:jar:1.0.0-SNAPSHOT"
> is something old.
> It was released some months and can be found on maven central. So settings
> xml is not needed anymore, and all
> of that was cleaned from Royale builds too to streamline maven process:
>
> Check the twit done in Nov 2019:
> https://twitter.com/ApacheFlex/status/1196869340290785280
>
>
>
> El sáb., 15 ago. 2020 a las 5:10, Maria Jose Esteve (<mjest...@iest.com>)
> escribió:
>
> > The develop branch is working.
> > More tomorrow.
> >
> > Hiedra.
> >
> > -----Mensaje original-----
> > De: Maria Jose Esteve <mjest...@iest.com>
> > Enviado el: sábado, 15 de agosto de 2020 1:00
> > Para: dev@royale.apache.org
> > Asunto: RE: Royale Echarts (was Re: Charts)
> >
> > Hahahha I got you wrong, I was talking about the library project [1] (I'm
> > working on the develop branch).
> >
> > I have taken note and change it in the example (I still have not managed
> > to compile it ☹ [2])
> >
> >
> >
> > [1]
> >
> https://github.com/mjesteve/Royale-ECharts/blob/develop/royale-echarts/pom.xml
> >
> > [2]
> >
> https://github.com/mjesteve/Royale-ECharts/tree/architecture/mjesteve_test2/royale-echarts-examples
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install
> > (default-install) on project royale-echarts-examples:
> > NoFileAssignedException: The packaging plugin for this project did not
> > assign a
> >
> > main file to the project but it has attachments. Change packaging to
> > 'pom'. -> [Help 1]
> >
> >
> >
> > Thx.
> >
> > Hiedra.
> >
> >
> >
> > -----Mensaje original-----
> > De: Brian Raymes <brian.ray...@teotech.com> Enviado el: viernes, 14 de
> > agosto de 2020 23:12
> > Para: dev@royale.apache.org
> > Asunto: RE: Royale Echarts (was Re: Charts)
> >
> >
> >
> > I don't see it as commented out in either of the pom.xml files within the
> > git repo that you shared:
> >
> >
> >
> >         <configuration>
> >
> >           <mainClass>App.mxml</mainClass>
> >
> >           <targets>SWF,JSRoyale</targets>          <-- This is what I
> > would change to simply <targets>JSRoyale</targets>
> >
> >         </configuration>
> >
> >
> >
> >
> >
> > Brian
> >
> >
> >
> > -----Original Message-----
> >
> > From: Maria Jose Esteve <mjest...@iest.com<mailto:mjest...@iest.com>>
> >
> > Sent: Friday, August 14, 2020 12:30 PM
> >
> > To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> >
> > Subject: RE: Royale Echarts (was Re: Charts)
> >
> >
> >
> > Hi Brian,
> >
> > Thanks for the help.
> >
> > I have deleted the .mvn directory as you indicate and the <target> tag
> had
> > it "Commented / * * /". Do I have to uncomment it and leave only
> JSRoyale?
> >
> >
> >
> > Thx.
> >
> > Hiedra
> >
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>


-- 

Piotr Zarzycki

Reply via email to