Maria, I wouldn't change implementation. That may matter later when I start using echart lib itself. I'm interested only in what is inside royale-echarts folder. - Next is how to use library this part is inside royale-echarts-example.
As a user of your implementation I would take swc - this will be result of build royale-echarts folder. I'm saying that some part of example folder should be moved to royale-echarts, so user who take library will have a way of implementing his version of echarts in more abstracted way. To me it sounds that IEchartDefinition - should be part of royale-charts, cause it describe how chart should be initialized. User will take your library royale-echarts.swc and using interface provided inside that swc will implement his class - which run chart - for example Pie chart. wt., 3 lis 2020 o 19:39 Maria Jose Esteve <mjest...@iest.com> napisał(a): > In the / echarts folder the basic component is created to add it in an > mxml tag (EChartsBasicControl and EChartsWithThemeControl). There is also a > bead to load themes and another to interact with it through its events. > I also started implementing a custom "theme loader" but it's half done ... > > Would you just change the IEChartsBasic? > > Hiedra. > > -----Mensaje original----- > De: Piotr Zarzycki <piotrzarzyck...@gmail.com> > Enviado el: martes, 3 de noviembre de 2020 19:22 > Para: Apache Royale Development <dev@royale.apache.org> > Asunto: Re: Royale Echarts (was Re: Charts) > > Maria, > > What do you mean whole folder ? I was just saying that his specific > interfaces should maybe be part of /royale-echarts/ folder. That's all. > > I was able to build library itself and example. > > Thanks, > Piotr > > wt., 3 lis 2020 o 19:11 Maria Jose Esteve <mjest...@iest.com> napisał(a): > > > Hello Piotr, > > yes, the whole ./echarts folder, included in the example project > > should be in the library but GIVES ME ERRORS when compiling it. (as > > soon as I refer to any class or object other than the basic types it > > gives me errors) Chris commented, after ApacheCon we had to go through > > it all and make some adjustments, but we haven't started yet. Maybe > > now is the time and the three of us can do it well (and everyone who > > wants to contribute, of course) > > > > Hiedra > > > > -----Mensaje original----- > > De: Piotr Zarzycki <piotrzarzyck...@gmail.com> Enviado el: martes, 3 > > de noviembre de 2020 17:41 > > Para: Apache Royale Development <dev@royale.apache.org> > > Asunto: Re: Royale Echarts (was Re: Charts) > > > > Hi Maria, > > > > I have reviewed your ECharts implementation and I see one things which > > may or may not be an improvement. In example application there is > > interface IEchartDefinition. I feel like it should be part of EChart lib > itself. > > > > I will try to use your implementation and see if I'm enough > > comfortable with it to replace mine. > > > > Thanks, > > Piotr > > > > sob., 15 sie 2020 o 11:23 Carlos Rovira <carlosrov...@apache.org> > > napisał(a): > > > > > Hi, > > > > > > As Brian said > > > > > > > > > "org.apache.royale.utilities.converter:flex-sdk-converter-maven-extension:jar:1.0.0-SNAPSHOT" > > > is something old. > > > It was released some months and can be found on maven central. So > > > settings xml is not needed anymore, and all of that was cleaned from > > > Royale builds too to streamline maven process: > > > > > > Check the twit done in Nov 2019: > > > https://twitter.com/ApacheFlex/status/1196869340290785280 > > > > > > > > > > > > El sáb., 15 ago. 2020 a las 5:10, Maria Jose Esteve > > > (<mjest...@iest.com>) > > > escribió: > > > > > > > The develop branch is working. > > > > More tomorrow. > > > > > > > > Hiedra. > > > > > > > > -----Mensaje original----- > > > > De: Maria Jose Esteve <mjest...@iest.com> Enviado el: sábado, 15 > > > > de agosto de 2020 1:00 > > > > Para: dev@royale.apache.org > > > > Asunto: RE: Royale Echarts (was Re: Charts) > > > > > > > > Hahahha I got you wrong, I was talking about the library project > > > > [1] (I'm working on the develop branch). > > > > > > > > I have taken note and change it in the example (I still have not > > > > managed to compile it ☹ [2]) > > > > > > > > > > > > > > > > [1] > > > > > > > https://github.com/mjesteve/Royale-ECharts/blob/develop/royale-echar > > > ts > > > /pom.xml > > > > > > > > [2] > > > > > > > https://github.com/mjesteve/Royale-ECharts/tree/architecture/mjestev > > > e_ > > > test2/royale-echarts-examples > > > > > > > > [ERROR] Failed to execute goal > > > > org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install > > > > (default-install) on project royale-echarts-examples: > > > > NoFileAssignedException: The packaging plugin for this project did > > > > not assign a > > > > > > > > main file to the project but it has attachments. Change packaging > > > > to 'pom'. -> [Help 1] > > > > > > > > > > > > > > > > Thx. > > > > > > > > Hiedra. > > > > > > > > > > > > > > > > -----Mensaje original----- > > > > De: Brian Raymes <brian.ray...@teotech.com> Enviado el: viernes, > > > > 14 de agosto de 2020 23:12 > > > > Para: dev@royale.apache.org > > > > Asunto: RE: Royale Echarts (was Re: Charts) > > > > > > > > > > > > > > > > I don't see it as commented out in either of the pom.xml files > > > > within the git repo that you shared: > > > > > > > > > > > > > > > > <configuration> > > > > > > > > <mainClass>App.mxml</mainClass> > > > > > > > > <targets>SWF,JSRoyale</targets> <-- This is what I > > > > would change to simply <targets>JSRoyale</targets> > > > > > > > > </configuration> > > > > > > > > > > > > > > > > > > > > > > > > Brian > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Maria Jose Esteve > > > > <mjest...@iest.com<mailto:mjest...@iest.com>> > > > > > > > > Sent: Friday, August 14, 2020 12:30 PM > > > > > > > > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > > > > > > > > Subject: RE: Royale Echarts (was Re: Charts) > > > > > > > > > > > > > > > > Hi Brian, > > > > > > > > Thanks for the help. > > > > > > > > I have deleted the .mvn directory as you indicate and the <target> > > > > tag > > > had > > > > it "Commented / * * /". Do I have to uncomment it and leave only > > > JSRoyale? > > > > > > > > > > > > > > > > Thx. > > > > > > > > Hiedra > > > > > > > > > > > > > -- > > > Carlos Rovira > > > http://about.me/carlosrovira > > > > > > > > > -- > > > > Piotr Zarzycki > > > > > -- > > Piotr Zarzycki > -- Piotr Zarzycki
