Ok ... so I just pushed another change. Now the distribution should also contain an empty spark.css, just like the Ant one.
Chris -----Ursprüngliche Nachricht----- Von: Christofer Dutz <christofer.d...@c-ware.de> Gesendet: Donnerstag, 18. Februar 2021 15:58 An: dev@royale.apache.org Betreff: AW: Align Maven IDE distribution with Ant IDE distribution Ok, so that should now be fixed. Leaves the "spark.css" Having had a look, it seems as if the Ant build creates an empty spark.css. Is this all we need? If yes, then I'll have that in ther in no time. Chris -----Ursprüngliche Nachricht----- Von: Piotr Zarzycki <piotrzarzyck...@gmail.com> Gesendet: Donnerstag, 18. Februar 2021 15:54 An: Apache Royale Development <dev@royale.apache.org> Betreff: Re: Align Maven IDE distribution with Ant IDE distribution *(I assume that's in the "frameworks/js/libs" directory? * Yes this is the directory. czw., 18 lut 2021 o 15:51 Christofer Dutz <christofer.d...@c-ware.de> napisał(a): > Hi Piotr, > > Ok ... so Ant seems to be adding a "JS" to the end of every name (I > assume that's in the "frameworks/js/libs" directory? > > Also I'll try to find out where the "spark.css" should come from ... > and where it should go to. > > Chris > > > -----Ursprüngliche Nachricht----- > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com> > Gesendet: Donnerstag, 18. Februar 2021 15:47 > An: Apache Royale Development <dev@royale.apache.org> > Betreff: Re: Align Maven IDE distribution with Ant IDE distribution > > Chris, > > Looks better but here is the comparision what I have in Ant > distribution vs Maven distribution in case of names. On the left Ant > distribution, on the right Maven. It is folder: frameworks\js\libs\ > [1] > > [1] https://ibb.co/W2DzcDb > > czw., 18 lut 2021 o 15:22 Christofer Dutz <christofer.d...@c-ware.de> > napisał(a): > > > And done ... > > > > Now all elements in the distribution only consist of their name and > > file-ending ... all versions and classifiers have been removed. > > Please provide me with feedback on if this solves the issues. > > > > Chris > > > > > > -----Ursprüngliche Nachricht----- > > Von: Christofer Dutz <christofer.d...@c-ware.de> > > Gesendet: Donnerstag, 18. Februar 2021 15:08 > > An: dev@royale.apache.org > > Betreff: AW: Align Maven IDE distribution with Ant IDE distribution > > > > I'll probably have a fix for that in a few minuntes ... > > > > > > Chris > > > > > > -----Ursprüngliche Nachricht----- > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com> > > Gesendet: Donnerstag, 18. Februar 2021 15:00 > > An: Apache Royale Development <dev@royale.apache.org> > > Betreff: Re: Align Maven IDE distribution with Ant IDE distribution > > > > Chris, > > > > No it's not about not picking up by IDE at all. Moonshine and VSCode > > are able to build projects using Maven distribution package! It is > > about project which are mixed for example when user wanted to use > > Jewel module + RemoteObject class from MXRoyale module. In that case > > user need to point explicilty as a compiler options in IDE that he > > wanted to have SWC included and need to exclude css from that swc to > avoid problems. > > > > It is happen like that: > > > > -js-library-path+=${royalelib}/js/libs/MXRoyaleJS.swc > > -compiler.exclude-defaults-css-files=MXRoyaleJS.swc:defaults.css > > > > If I would like to use maven distribution user need to know version > > for that compiler options. It is even more tricky when your swc is > > called > > -> MXRoyale-0.9.8-20210217.181012-913-js.swc > > > > -exclude-defaults-css-files=MXRoyale-0.9.8-js.swc:defaults.css > > > > Thanks, > > Piotr > > > > > > > > > > czw., 18 lut 2021 o 14:47 Christofer Dutz > > <christofer.d...@c-ware.de> > > napisał(a): > > > > > Hi Piotr, > > > > > > And is really the version-suffix causing it to not be picked up by > > > the IDEs? > > > > > > Chris > > > > > > -----Ursprüngliche Nachricht----- > > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com> > > > Gesendet: Donnerstag, 18. Februar 2021 11:42 > > > An: dev@royale.apache.org > > > Betreff: Re: Align Maven IDE distribution with Ant IDE > > > distribution > > > > > > Hi Chris, > > > > > > This is the only thing which seems to be a constant problem here. > > > I personally and some users will be much more happy having that change. > > > > > > Thanks, > > > Piotr > > > > > > On Thu, 18 Feb 2021 at 11:03, Christofer Dutz > > > <christofer.d...@c-ware.de> > > > wrote: > > > > > > > Hi Piotr, > > > > > > > > I'd be happy to help with that. > > > > > > > > I did simply ask for a list of things that need to be changed in > > > > order to get things working, but never got said list, so I never > > > > knew what I could do to make the Maven distribution match up to > > > > the > > Ant built one. > > > > > > > > Chris > > > > > > > > > > > > -----Ursprüngliche Nachricht----- > > > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com> > > > > Gesendet: Donnerstag, 18. Februar 2021 11:01 > > > > An: Apache Royale Development <dev@royale.apache.org> > > > > Betreff: Align Maven IDE distribution with Ant IDE distribution > > > > > > > > Hi Guys, > > > > > > > > It's been couple of times when user complains that he have > > > > problems with using Maven distribution vs Ant distribution in > > > > IDE in a mixed project Jewel + MX/Spark etc. > > > > > > > > Can we have that resolve once for all and adjust Maven > > > > distribution folder to produce proper names of swcs ? > > > > > > > > Currently when I build Maven IDE distribution I have: > > > > > > > > MXRoyale-0.9.8-20210215.234230-908-js.swc > > > > > > > > When I build Ant IDE distribution I have: > > > > > > > > MXRoyale-js.swc > > > > > > > > Thanks, > > > > -- > > > > > > > > Piotr Zarzycki > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > > > > -- > > > > Piotr Zarzycki > > > > > -- > > Piotr Zarzycki > -- Piotr Zarzycki
