> The ant examples are only built after release approval. Actually, I think I misread the scripts. I don’t think examples are built with ant anywhere in the release process except upon approval. If somebody wants to inform otherwise please do.
From: Yishay Weiss<mailto:yishayj...@hotmail.com> Sent: Thursday, March 17, 2022 9:12 AM To: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev>; dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3 The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread. Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common. I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick. Thanks. [1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/view/Royale_Release_Steps/job/Royale_Release_Step_011/26/consoleFull> [2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >--------------- [INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265] [INFO] [INFO] --------------------------------[ swf ]--------------------------------- [INFO] [INFO] [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample --- [INFO] [INFO] [INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample --- [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources [INFO] [INFO] [INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample --- [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets [INFO] [INFO] [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample --- [INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4 [INFO] [INFO] Copying 3 resources from 1 bundle. [INFO] [INFO] [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample --- [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources [INFO] [INFO] Copying 3 resources [INFO] [INFO] [INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample --- [INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml] [INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml [INFO] [INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds [INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary [INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed [INFO] The project 'MenuExample' has been successfully compiled and optimized. From: Yishay Weiss<mailto:yishayj...@hotmail.com> Sent: Wednesday, March 16, 2022 7:14 AM To: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev>; dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3 Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI. My CLT-L09. On O2. -------- Original message -------- From: Josh Tynjala <joshtynj...@bowlerhat.dev> Date: Tue, 15 Mar 2022, 23:07 To: dev@royale.apache.org Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3 I ran into two separate issues with the approval script. The first issue was the ASDoc example build failing in the JS-only SDK, which I discovered was happening because I didn't realize that I had an AIR_HOME environment variable set externally. I cleared AIR_HOME, and that's fixed it for me. No RC needed for this. The second issue was the MenuExample example build failing. My commit today fixes that. A new RC is needed to resolve this one with my commit. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yishayj...@hotmail.com> wrote: > I’m not following. Was the problem AIR_HOME or what your latest commit > fixed? Do we need another RC? > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Tuesday, March 15, 2022 10:01 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3 > > I discovered that I had an AIR_HOME environment variable set elsewhere, and > that was causing the ASDoc build failure. In the approval script, I can now > reach MenuExample with both use-flash and without. > > I pushed a commit to develop that fixes the MenuExample build issue. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <joshtynj...@bowlerhat.dev> > wrote: > > > When running the approval script *without* -Duse-flash=true (in other > > words, JS-only), I get the following error when it tries to build the > ASDoc > > example. However, it seems to build that example correctly when I use > > -Duse-flash=true. > > > > json: > > ROYALE_COMPILER_HOME: > > > /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js > > 16.6482905 seconds > > java.lang.NullPointerException: Cannot invoke > > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because > "node" > > is null > > org.apache.royale.compiler.internal.codegen.as > .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler. > internal.codegen.as > .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107) > > > > With -Duse-flash=true, I was able to get ASDoc built, but it fails on > > building MenuExample later. This is the error: > > > > > apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34): > > col: 3 Error: This tag could not be resolved to an ActionScript class. It > > will be ignored. > > > > <royale:MyInitialView /> > > > > The issue seems to be caused by this commit: > > > > > > > https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f > > > > The source path should not have been changed from src/main/royale to src. > > The correct source path is src/main/royale for all examples and libraries > > in Royale. > > > > I will see if I can get these issues fixed for the next RC. As things > > are right now, I would vote -1. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Sun, Mar 13, 2022 at 11:35 PM <apacheroyal...@gmail.com> wrote: > > > >> This is the discussion thread. > >> > >> Thanks, > >> Yishay Weiss > > > > > >
