That was what I was getting at. On github I would look it over, put any comments I had, and then push it to Roshan or Aaron if it was controversial or if I wasn't familiar with the projects being affected. If it wasn't controversial, I would just merge the request. I'm not sure if that's transparent enough though.
Sent from my iPad > On Dec 1, 2015, at 8:52 PM, Adina Crainiceanu <[email protected]> wrote: > > So we should review each pull request, even from committers, but what are > the steps of the review? > > On Tue, Dec 1, 2015 at 4:34 PM, Lotts, David <[email protected]> > wrote: > >> I'm reviewing it, but others should also. This is a big one, and I'm not >> familiar with testing everything. >> david. >> >> -----Original Message----- >> From: Puja Valiyil [mailto:[email protected]] >> Sent: Tuesday, December 01, 2015 4:26 PM >> To: [email protected] >> Subject: Re: [jira] [Commented] (RYA-7) Various pom cleanups for the >> Apache move >> >> What's the process we're following here? Should someone other than Aaron >> review it, or can he merge the pull request directly? >> Also I created a bug against Rya backed by Mongo DB -- I put the component >> as "mongodao". >> >> On Tue, Dec 1, 2015 at 3:18 PM, ASF GitHub Bot (JIRA) <[email protected]> >> wrote: >> >>> >>> [ >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org >>> _jira_browse_RYA-2D7-3Fpage-3Dcom.atlassian.jira.plugin.system.issueta >>> bpanels-3Acomment-2Dtabpanel-26focusedCommentId-3D15034500-23comment-2 >>> D15034500&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF7EKmrYIdfxIq10&r=ruy >>> 1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5rlVxL_17AaiWmKh5YpCG >>> p3Z0miAST90jwTCY&s=Ta8x-IrOjrgJRfMzKnP4uZANWGthIo0OrR-TEUp0Q9c&e= >>> ] >>> >>> ASF GitHub Bot commented on RYA-7: >>> ---------------------------------- >>> >>> GitHub user amihalik opened a pull request: >>> >>> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache >>> _incubator-2Drya_pull_2&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF7EKmrY >>> IdfxIq10&r=ruy1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5rlVxL_ >>> 17AaiWmKh5YpCGp3Z0miAST90jwTCY&s=Tgf96G9gdVR3AKWJ5vfdvru2VBj5boW-Q3h34 >>> 27o23o&e= >>> >>> RYA-7 POM and License Clean-up for Apache Move >>> >>> Numerous POM and License Mods: >>> - Make the apache pom the parent >>> - Depend on Apache releases for Hadoop and ZooKeeper >>> - Updated to most recent bug-fix release for dependencies >>> - Moved Deps to Parent POM >>> - Change groupId from mvn.rya to org.apache.rya >>> - Set proper names for each maven module >>> - Fix SCM block in parent pom >>> - Remove Dead/CB Projects >>> - Remove Extra Repos/Profiles >>> - Moved rya.sail.impl to rya.sail >>> >>> You can merge this pull request into a Git repository by running: >>> >>> $ git pull >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_amihal >>> ik_incubator-2Drya&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF7EKmrYIdfxI >>> q10&r=ruy1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5rlVxL_17Aai >>> WmKh5YpCGp3Z0miAST90jwTCY&s=Ka-e9IILKLUUZ45TChRCkwVnmnX-OL3rQsWvrz0Cxq >>> M&e= mihalik/RYA-7 >>> >>> Alternatively you can review and apply these changes as the patch at: >>> >>> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache >>> _incubator-2Drya_pull_2.patch&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF >>> 7EKmrYIdfxIq10&r=ruy1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5 >>> rlVxL_17AaiWmKh5YpCGp3Z0miAST90jwTCY&s=mNQXmMjOdgP9L2-XNgvXotaXH5kYG3- >>> W5VXcUYLsZ80&e= >>> >>> To close this pull request, make a commit to your master/trunk branch >>> with (at least) the following in the commit message: >>> >>> This closes #2 >>> >>> ---- >>> commit 3238bf27143faf1fecd71c6dd22f9ed3c02f4057 >>> Author: Aaron Mihalik <[email protected]> >>> Date: 2015-12-01T20:11:17Z >>> >>> RYA-7 POM and License Clean-up for Apache Move >>> >>> Numerous POM and License Mods: >>> - Make the apache pom the parent >>> - Depend on Apache releases for Hadoop and ZooKeeper >>> - Updated to most recent bug-fix release for dependencies >>> - Moved Deps to Parent POM >>> - Change groupId from mvn.rya to org.apache.rya >>> - Set proper names for each maven module >>> - Fix SCM block in parent pom >>> - Remove Dead/CB Projects >>> - Remove Extra Repos/Profiles >>> - Moved rya.sail.impl to rya.sail >>> >>> ---- >>> >>> >>>> Various pom cleanups for the Apache move >>>> ---------------------------------------- >>>> >>>> Key: RYA-7 >>>> URL: >> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_RYA-2D7&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF7EKmrYIdfxIq10&r=ruy1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5rlVxL_17AaiWmKh5YpCGp3Z0miAST90jwTCY&s=U0kQ9ZJm-TAVYBIGU2MONOUCjdy-Xo1qtqh6Gs-2U78&e= >>>> Project: Rya >>>> Issue Type: Task >>>> Reporter: Josh Elser >>>> Assignee: Aaron Mihalik >>>> Fix For: 3.2.10 >>>> >>>> >>>> In working on RYA-5, I noticed a few things in the pom that I >>>> believe >>> should be taken care of before a release. >>>> * Make the apache pom the parent (see >>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__maven.apache.or >>>> g_pom_asf_&d=BQIBaQ&c=Nwf-pp4xtYRe0sCRVM8_LWH54joYF7EKmrYIdfxIq10&r= >>>> ruy1rriFBFoeOJvvQWwN1h8AcdSNT3EVLrdVl7pr-iA&m=KOXAYN5rlVxL_17AaiWmKh >>>> 5YpCGp3Z0miAST90jwTCY&s=Gf96eav2DJmE_Mo3pxhsq-xcf58p5MoIn_9dg4Mipec& >>>> e= ) >>>> * Depend on Apache releases for Hadoop and ZooKeeper (and groovy?) >>>> * Make sure we're depending on the most recent bug-fix release for >>> dependencies (e.g. upgrade from 1.6.2 to 1.6.4 for Accumulo) >>>> * Change groupId from {{mvn.rya}} to {{org.apache.rya}} for >>>> consistency >>> with other Maven-based ASF projects >>>> * Set proper names for each maven module (instead of groupid.artifact). >>> This isn't as critical to change for a release, but just is an easy >>> thing to improve. >>>> * Fix SCM block in parent pom (points to incorrect repository). >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) > > > > -- > Dr. Adina Crainiceanu > http://www.usna.edu/Users/cs/adina/
