[
https://issues.apache.org/jira/browse/RYA-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036254#comment-15036254
]
ASF GitHub Bot commented on RYA-7:
----------------------------------
Github user joshelser commented on the pull request:
https://github.com/apache/incubator-rya/pull/2#issuecomment-161380000
Took a glance, and it looks alright to me. I haven't put a close eye to
whether the LICENSE and NOTICE files are actually correct (not a super high
priority at Rya's current stage in life).
Lots of nice fixes to the poms. Thanks for taking the time to work on this.
A minor nit is that it would be better to push down the rat-plugin
exclusions to each module (rather than defining it in the parent pom). This
helps make sure we know _exactly_ what is being ignored and we don't
accidentally ignore something new in the future.
> Various pom cleanups for the Apache move
> ----------------------------------------
>
> Key: RYA-7
> URL: https://issues.apache.org/jira/browse/RYA-7
> Project: Rya
> Issue Type: Task
> Reporter: Josh Elser
> Assignee: Aaron Mihalik
> Fix For: 3.2.10
>
>
> In working on RYA-5, I noticed a few things in the pom that I believe should
> be taken care of before a release.
> * Make the apache pom the parent (see https://maven.apache.org/pom/asf/)
> * Depend on Apache releases for Hadoop and ZooKeeper (and groovy?)
> * Make sure we're depending on the most recent bug-fix release for
> dependencies (e.g. upgrade from 1.6.2 to 1.6.4 for Accumulo)
> * Change groupId from {{mvn.rya}} to {{org.apache.rya}} for consistency with
> other Maven-based ASF projects
> * Set proper names for each maven module (instead of groupid.artifact). This
> isn't as critical to change for a release, but just is an easy thing to
> improve.
> * Fix SCM block in parent pom (points to incorrect repository).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
