[
https://issues.apache.org/jira/browse/S2GRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093590#comment-15093590
]
ASF GitHub Bot commented on S2GRAPH-14:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/2
S2GRAPH-14: Abstract HBase specific methods in Management and Label.
* Remove Management.createService from Label/Service.
* Add Management class and move createService/createLabel/createTable from
Management object into Management class.
* Refactor caller of above methods according to changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-14
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit b9b9e710e0b194ad55d0a067eda84a4cf9d0fc70
Author: SteamShon <[email protected]>
Date: 2015-12-02T07:09:33Z
reduce max idle ttl to 10 seconds
commit 957e95fe6e476b83bf6085c243087438aa77f4de
Author: SteamShon <[email protected]>
Date: 2016-01-06T05:28:58Z
S2GRAPH-14: add Management class and move createTable, createService,
createLabel into class. fix caller of theses methods
----
> Abstract HBase specific methods in Management and Label.
> --------------------------------------------------------
>
> Key: S2GRAPH-14
> URL: https://issues.apache.org/jira/browse/S2GRAPH-14
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Minor
> Labels: refactoring
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Management have some helper methods to create, delete hbase table and get
> hbase admin.
> we refactor Graph class to make possible for others to use different storage
> backend but Management class has been left out. to support others to
> implement different storage backend other than hbase, we need to abstract
> hbase specific code on Management too. also Label.insertAll method create
> hbase table inside which doesn`t looks right. model classes(under mysql
> package) should not depends on specific storage backend.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
