[
https://issues.apache.org/jira/browse/S2GRAPH-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101148#comment-15101148
]
ASF GitHub Bot commented on S2GRAPH-14:
---------------------------------------
Github user hsleep commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/2#issuecomment-171864080
@SteamShon
Please resolve conflicts.
> Abstract HBase specific methods in Management and Label.
> --------------------------------------------------------
>
> Key: S2GRAPH-14
> URL: https://issues.apache.org/jira/browse/S2GRAPH-14
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Minor
> Labels: refactoring
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Management have some helper methods to create, delete hbase table and get
> hbase admin.
> we refactor Graph class to make possible for others to use different storage
> backend but Management class has been left out. to support others to
> implement different storage backend other than hbase, we need to abstract
> hbase specific code on Management too. also Label.insertAll method create
> hbase table inside which doesn`t looks right. model classes(under mysql
> package) should not depends on specific storage backend.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
